1820569 - Implement webRequestAuthProvider permission for webRequest.onAuthRequired

Status: RESOLVED FIXED

(WebExtensions :: Request Handling, enhancement, P3)

Description

[Rob Wu [:robwu]]

Chrome introduced the "webRequestAuthProvider" as a replacement for the "webRequestBlocking" permission, because they are rejecting the latter in MV3.

Firefox continues to support "webRequestBlocking" in MV3, so it is not strictly necessary to introduce another permission. But for cross-browser compatibility, it may make sense to also implement the "webRequestAuthProvider" permission so that extension authors can use the webRequest.onAuthRequired event with only the "webRequest" + "webRequestAuthProvider" permissions (without requiring "webRequestBlocking").

Relevant references:

• https://bugs.chromium.org/p/chromium/issues/detail?id=1135492#c93
• https://github.com/w3c/webextensions/issues/264

Comment 1

[Rob Wu [:robwu]]

Documentation request: https://github.com/mdn/content/issues/21586

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1820569 - Implement webRequestAuthProvider permission for webRequest.onAuthRequired. r?robwu!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/68dfd8b189e7
Implement webRequestAuthProvider permission for webRequest.onAuthRequired. r=robwu

Comment 4

[Iulian Moraru]

Backed out for causing xpcshell failures on test_ext_webRequest_permission.js.

• Push with failures

• Failure log

• Backout link

Comment 5

[Luca Greco [:rpl] [:luca] [:lgreco]]

(In reply to Iulian Moraru from comment #4)

Backed out for causing xpcshell failures on test_ext_webRequest_permission.js.

• Push with failures

• Failure log

• Backout link

sorry about that, I'm not yet sure why but I just didn't hit this failure when I execute all xpcshell tests locally and the test assertion failing seems to not be just updated to expect the updated error expected to be logged in the scenario being tested, I'm taking a look and will update the patch shortly.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4ff2d940080
Implement webRequestAuthProvider permission for webRequest.onAuthRequired. r=robwu

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/e4ff2d940080

Comment 8

[rbloor]

MDN updates available for review:

• BCD Add manifest permissions.webRequestAuthProvider supported from FF126 #22839
• content Release notes for manifest permissions.webRequestAuthProvider support #33151