1820640 - Add support for embedding the new MigrationWizard in about:welcome's onboarding cards

Status: RESOLVED FIXED

(Firefox :: Migration, task, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

The new Migration Wizard isn't done yet, but already we've made some pretty big strides. It can be embedded in about:welcome, for example. It's not a perfect experience - there's definitely some styling tweaks required - but it functions. See attached video.

This bug is about landing some prerequisites and infrastructure to make it possible to embed the wizard in about:welcome.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1820640 - Enforce left-alignment and expose the button containers for the new Migration Wizard. r?kpatenio!

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Demo video

Comment 3

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Seems like this is a thing on the roadmap we're really planning to do; triaging accordingly.

Comment 4

[Punam Dahiya [:pdahiya]]

Attachment: About Welcome Embed Import Figma designs

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1820640 - Add a card to about:welcome that embeds the Migration Wizard if configured to do so. r?pdahiya!

This adds a card to the about:welcome defaults that embeds the new Migration Wizard
if browser.migrate.content-modal.about-welcome-behavior is set to "embedded".

This requires adding a useEmbeddedMigrationWizard targeting attribute to
ASRouterTargeting.

Depends on D171771

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2530a56ab91d
Enforce left-alignment and expose the button containers for the  new Migration Wizard. r=kpatenio
https://hg.mozilla.org/integration/autoland/rev/782d8d51ecd4
Add a card to about:welcome that embeds the Migration Wizard if configured to do so. r=pdahiya,omc-reviewers

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2530a56ab91d
https://hg.mozilla.org/mozilla-central/rev/782d8d51ecd4

Comment 8

[Martin Thomson [:mt:]]

This change introduced a documentation bug, see https://firefox-source-docs.mozilla.org/browser/components/newtab/content-src/asrouter/docs/targeting-attributes.html: "[useEmbeddedMigrationWizard][#useembeddedmigrationwizard]"

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Thanks, mt - I filed bug 1869327 to fix that.