Closed Bug 1820684 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 38839 - Add support for non-positive resolutions to image-set

Categories

(Core :: Layout: Images, Video, and HTML Frames, task, P4)

Product:
Core
Component:
Layout: Images, Video, and HTML Frames
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
113 Branch
Tracking Flags:
Tracking Status
firefox113 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Depends on 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 38839 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/38839
Details from upstream follow.

Traian Captan <tcaptan@chromium.org> wrote:

Add support for non-positive resolutions to image-set

This change was triggered by the recently added wpt tests that started
failing after auto import:
third_party/blink/web_tests/external/wpt/css/css-images/image-set/image-set-zero-resolution-rendering.html
third_party/blink/web_tests/external/wpt/css/css-images/image-set/image-set-zero-resolution-rendering-2.html

Currently the spec does not restrict the range for resolution,
thus non-positive resolutions are valid and should not be
rejected at parse time.

The current consensus is to parse the non-positive resolutions,
but treat them as unsupported options for rendering purposes.

With this change, image-set will match resolution parsing
with media queries.

An issue has been opend for the spec to define the valid
argument range for resolution:
https://github.com/w3c/csswg-drafts/issues/8532

R=futhark, pdr

Change-Id: I7b329519168f3c088f5c9ee8614931b0ead7a4df
Reviewed-on: https://chromium-review.googlesource.com/4312883
WPT-Export-Revision: 898a7b2ddf65ecd1166e370293012bdd3f003dc7

Component: web-platform-tests → Layout: Images, Video, and HTML Frames
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Test result changes from PR not available.
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/516d31839b5a [wpt PR 38839] - Add support for non-positive resolutions to image-set, a=testonly
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/516d31839b5a

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox113: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
You need to log in before you can comment on or make changes to this bug.