1820720 - Don't use -no-integrated-as for Pixman on Android/arm

Status: RESOLVED FIXED

(Core :: Graphics, task, P2)

Description

[Makoto Kato [:m_kato]]

GeckoView team is considering to upgrade NDK to r25 that is the latest TLS version since Rust compiler will be upgrade to 1.68. It is built by NDK r25.

NDK r25 removes GNU assembler, so I would like to port NEON optimization code to clang/LLVM compatible.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:bhood, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Makoto Kato [:m_kato]]

Attachment: Bug 1820720 - Part 1. Import https://gitlab.freedesktop.org/pixman/pixman/-/merge_requests/71. r=#gfx-reviewers

Actually, we need GNU AS to build the assembler files in pixman. This fix
removes GNU AS dependency for aarch64 assembler files.

Comment 3

[Makoto Kato [:m_kato]]

Attachment: Bug 1820720 - Part 2. Import https://gitlab.freedesktop.org/pixman/pixman/-/issues/74. r=#gfx-reviewers.

This is arm32 issue to build clang only.

Depends on D183969

Comment 4

[Makoto Kato [:m_kato]]

Attachment: Bug 1820720 - Part 3. Add patch files. r=#gfx-reviewers

Depends on D183970

Comment 5

[Makoto Kato [:m_kato]]

Attachment: Bug 1820720 - Part 4. Don't use -no-integrated-as to build assembler files. r=#gfx-reviewers

It is unnecessary to use -no-integrated-as to build assembler files.
So let's remove it.

Depends on D183971

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f19c6f5b8673
Part 1. Import https://gitlab.freedesktop.org/pixman/pixman/-/merge_requests/71. r=gfx-reviewers,lsalzman
https://hg.mozilla.org/integration/autoland/rev/1729776917d4
Part 2. Import https://gitlab.freedesktop.org/pixman/pixman/-/issues/74. r=gfx-reviewers,lsalzman.
https://hg.mozilla.org/integration/autoland/rev/1b862fa12e1d
Part 3. Add patch files. r=gfx-reviewers,lsalzman
https://hg.mozilla.org/integration/autoland/rev/bde980d8d04b
Part 4. Don't use -no-integrated-as to build assembler files. r=gfx-reviewers,lsalzman

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/f19c6f5b8673
https://hg.mozilla.org/mozilla-central/rev/1729776917d4
https://hg.mozilla.org/mozilla-central/rev/1b862fa12e1d
https://hg.mozilla.org/mozilla-central/rev/bde980d8d04b