1820738 - Use a custom Module base class for WebDriver BiDi

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, enhancement, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

It might be helpful to have a custom base class for the MessageHandler's Module class just dedicated for WebDriver BiDi. Hereby we could add more properties like getting the nodeCache or the processActor which should not be done in the MessageHandler's implementation because that's WebDriver related.

We should discuss if that is an option and if yes which other properties and methods might be helpful to have as well.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

We agreed on that a dedicated Module base class for WebDriver BiDi would be helpful. We can get started with sub-classing the message manager class and provide access to the processActor, and additionally a shortcut to the nodeCache.

The implementation should take place in the remote/webdriver-bidi folder and the file name can be as well stay with Module.sys.jsm.

Comment 2

[Victoria Ajala]

Hi, I would be working on this bug @whimboo

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Sounds good! Let me know if you have questions. Happy to discuss / explain on Matrix.

Comment 4

[Victoria Ajala]

Sorry for the delay @whimboo, If I understand you correctly in comment 2, I would be adding a Module base class for WebDriver BiDi. Could you elaborate on that for me?

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Yes, that is correct. This BiDi specific Module class would inherit from the MessageManager module base class as referenced in comment 0. With this addition all the BiDi specific module implementations would then make use of the new class instead.

Comment 6

[Victoria Ajala]

Attachment: Bug 1820738 - Used a custom Module base class for WebDriver BiDi. r=whimboo

Comment 7

[Victoria Ajala]

Hi @whimboo, I attached a patch to this, I have only created the Module.sys.jsm file in remote/webdriver-bidi How do I get a base bidi module working like you mentioned in the comment?

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/903008b27dd0
Used a custom Module base class for WebDriver BiDi. r=jdescottes

Comment 9

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/903008b27dd0