1820743 - Allow to move unified extensions button on the navbar

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P3)

Description

[William Durand [:willdurand]]

This is a first (admittedly small) step towards more customization of the unified extensions UI.

Comment 1

[William Durand [:willdurand]]

Attachment: Bug 1820743 - Allow to move unified extensions button on the navbar. r?rpl!

Comment 2

[jscher2000]

Is anything preventing this patch from moving into testing in Nightly? (As a contributor, I don't have access to Jira to understand what else needs to be decided.)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56de7c6ac457
Allow to move unified extensions button on the navbar. r=rpl

Comment 4

[Cristina Horotan [:chorotan]]

Backed out changeset 56de7c6ac457 (bug 1820743) for causing bc failures at browser_toolbarKeyNav.js

Backout: https://hg.mozilla.org/integration/autoland/rev/941c44ba9486bbb17d63b1ee97a9eef269e075cf

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&test_paths=browser%2Fbase%2Fcontent%2Ftest%2Fperformance&revision=56de7c6ac457cecad5e5bf47a9d53909a9adf4a8&selectedTaskRun=D5DUjnV8Qg-ryaz_5_7KSA.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=409628533&repo=autoland&lineNumber=4200

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f365d0974c0
Allow to move unified extensions button on the navbar. r=rpl

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/7f365d0974c0

Comment 7

[jscher2000]

In a brief test, this allows moving the button in a similar manner to the non-removable Back button (i.e., only within the main navigation toolbar).

Any chance of uplift to Firefox 112?

Comment 8

[William Durand [:willdurand]]

(In reply to jscher2000 from comment #7)

Any chance of uplift to Firefox 112?

Maybe? I don't see why not but it'd be good to wait a bit more and make sure nothing is unexpectedly broken in Nightly.

Comment 9

[William Durand [:willdurand]]

Comment on attachment 9321579 [details]
Bug 1820743 - Allow to move unified extensions button on the navbar. r?rpl!

Beta/Release Uplift Approval Request

• User impact if declined: All users see the extensions button. It's hard to assess who really wants/needs to move this extensions button but we've been getting feedback about this button, e.g. it is less customizable than some other parts of the UI. Allowing to move this extensions button is a first (conservative) step in this direction and it'd be nice to offer this small change to all users in Beta.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It is low because the code change is fairly small (we move the definition of the button into the part of the navbar that allows buttons to be moved). The patch is covered by some automated tests and we didn't notice any regression in Nightly so far.
• String changes made/needed:
• Is Android affected?: No

Comment 10

[Dianna Smith [:diannaS]]

Comment on attachment 9321579 [details]
Bug 1820743 - Allow to move unified extensions button on the navbar. r?rpl!

We're unfortunately out of Beta builds for Fx112 this cycle in light of next week's RC. Given that this is an enhancement and the limited time for testing, it's probably best for this to ride 113 to release.

Comment 11

[William Durand [:willdurand]]

Makes sense, thanks!

Comment 12

[Kelimutu [:kiki]]

Is there any way I can move a button back to the UEB once I moved it to the navbar?

I can't seem to find a way to move it even from the Customize mode.

Comment 13

[William Durand [:willdurand]]

(In reply to Kelimutu [:kiki] from comment #12)

Is there any way I can move a button back to the UEB once I moved it to the navbar?

I can't seem to find a way to move it even from the Customize mode.

You can context-click on the button and uncheck "Pin to Toolbar" I think.

Comment 14

[Kelimutu [:kiki]]

Ah, didn't see that before. That did it, yeah. Thanks!

Comment 15

[Jim Jeffery not reading bug-mail 1/2/11]

I am on latest Nightly and Pin to Toolbar does not exist , Pin to Overflow are 'gray'd' out along with Remove from Toolbar.
What am I missing ?

Comment 16

[Jim Jeffery not reading bug-mail 1/2/11]

Attachment: Screenshot 2023-04-14 122252.png