1820784 - Result highlighting from project search with regex modifier do not seem correct

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

Attachment: incorrect highlighting

Steps to reproduce

1. Go to https://nchevobbe.github.io/demo/console-test-app.html
2. Open the debugger
3. Open the project file search
4. Enable regex modifier
5. Search the following term import .* from "react"

Expected results

import React from "react" is highlighted

Actual results

the highlighter is only added to import React from "rea

Comment 1

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1820784 - [devtools] Fix highlight matches for regex search results r=nchevobbe

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/70c2101251e2
[devtools] Fix highlight matches for regex search results r=nchevobbe,devtools-reviewers

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/70c2101251e2

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

bomsy, should we request an uplift since the regex search landed in 112 ?

Comment 5

[Hubert Boma Manilla (:bomsy)]

Comment on attachment 9321814 [details]
Bug 1820784 - [devtools] Fix highlight matches for regex search results r=nchevobbe

Beta/Release Uplift Approval Request

• User impact if declined: Wrong highlighting for regex project search results
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It a tiny fix and includes a test.
• String changes made/needed:
• Is Android affected?: No

Comment 6

[Dianna Smith [:diannaS]]

:bomsy does any part of bug 1803616 need to be uplifted as well to avoid bug 1819531 in fx112?

Comment 7

[Hubert Boma Manilla (:bomsy)]

Oh yeah it does, the change to devtools/client/debugger/dist/search-worker.js. But if that is complex, its fine to let this just ride the train.

Comment 8

[Dianna Smith [:diannaS]]

Comment on attachment 9321814 [details]
Bug 1820784 - [devtools] Fix highlight matches for regex search results r=nchevobbe

Approved for 112.0b5

Comment 9

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/26b88765dca5