1820792 - Improve logging around rkv opening

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, enhancement, P1)

Description

[Perry McManis [:perry.mcmanis]]

RKV gives us a handy error DatabaseCorrupted

let's add this to logging in new_rkv()

Comment 1

[BMO Automation]

Attachment: [mozilla/glean] Bug 1820792 - add DatabaseCorrupted error to logging in rkv_new (#2402)

Comment 2

[Travis Long [:travis_]]

On further consideration, adding this change that recreates the rkv database right now while we are trying to make measurements around this may make it more difficult by introducing new behavior. Let's comment this out and wait for the current investigation to resolve before continuing with this. I do think it's the correct course of action to match the behavior laid out in the comment in the code here, but it can wait a bit to land this.

Comment 3

[BMO Automation]

Attachment: [mozilla/glean] Bug 1820792 - Temporarily disable rkv_new in cases we detect a DatabaseCorrupted error (#2403)

Comment 4

[BMO Github Automation]

Attachment: [mozilla/glean] Bug 1820792 - Create new RKV on DatabaseCorrupted Error and log error (#2425)