Closed Bug 1820821 Opened 3 months ago Closed 3 months ago

Re-order PiP tests in pictureinpicture/tests/browser.ini alphabetically

Categories

(Toolkit :: Picture-in-Picture, task)

Product:
Toolkit
Component:
Picture-in-Picture
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
113 Branch
Tracking Flags:
Tracking Status
firefox113 --- fixed

People

(Reporter: kpatenio, Assigned: helloshahx95, Mentored)

Details

(Keywords: good-first-bug)

Attachments

(1 file, 2 obsolete files)

Bug 1820821 Re-order PiP tests in pictureinpicture/tests/browser.ini alphabetically. r=kpatenio
48 bytes, text/x-phabricator-request
Details | Review

Patches modifying browser.ini will get an ESLint warning about the test name order not being alphabetically sorted. Let's be sure to fix that.

Severity: -- → N/A
Mentor: kpatenio
Keywords: good-first-bug

Hi. I am an Outreachy applicant. I'd like to be assigned to this issue

Flags: needinfo?(tgiles)

Hi! Thanks for your interest. I assigned the ticket to you for the time being. Please reach out if you have any questions. Otherwise if there's no activity on the bug after a couple days, I might unassign the ticket to give other applicants a chance to work on a patch.

Assignee: nobody → helloshahx95
Status: NEW → ASSIGNED
Flags: needinfo?(tgiles)

Thanks, kpatenio. My setup took an unusually long time to complete, but the chat made me aware of SearchFox, so I'm currently familiarizing myself with the code on it and then will tackle the bug accordingly

Hi kpatenio! I am still in the trenches trying to get the setup going on my laptop. Since the fix did not require me to actually code with the source code, I have been able to get it done: https://pastebin.mozilla.org/N1xULrzA
Meanwhile, I am going to continue trying to troubleshoot and get my setup running soon.

(In reply to Shah from comment #4)

Hi kpatenio! I am still in the trenches trying to get the setup going on my laptop. Since the fix did not require me to actually code with the source code, I have been able to get it done: https://pastebin.mozilla.org/N1xULrzA
Meanwhile, I am going to continue trying to troubleshoot and get my setup running soon.

Thanks for the update! If you haven't checked it out already, the Introduction Matrix channel is available if you need assistance with your set up.

Hello kpatenio. Thank you for your suggestion. I was successfully able to set up Mozilla on my pc. I have submitted the patch for this bug: https://phabricator.services.mozilla.com/D172472

Attachment #9322824 - Attachment is obsolete: true
Attachment #9323101 - Attachment is obsolete: true
Attachment #9322822 - Attachment description: Bug 1820821 Re-order PiP tests in pictureinpicture/tests/browser.ini aphabetically. r=kpatenio → Bug 1820821 Re-order PiP tests in pictureinpicture/tests/browser.ini alphabetically. r=kpatenio
Pushed by kpatenio@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0e04b6eccd4c
Re-order PiP tests in pictureinpicture/tests/browser.ini alphabetically. r=kpatenio

https://hg.mozilla.org/mozilla-central/rev/0e04b6eccd4c

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
status-firefox113: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
You need to log in before you can comment on or make changes to this bug.