1820869 - limit building of unreachable libwebrtc files

Status: RESOLVED FIXED

(Core :: WebRTC, task, P2)

Description

[Michael Froman [:mjf]]

Bug 1819569 attempts remove files considered unreachable, but does so in a way that is incompatible with libwebrtc vendoring and directly modified generated moz.build files. We should modify BUILD.gn files to limit the building of those files considered unreachable without actually removing those files from the vendored library.

Files identified as unreachable:

#### Cluster 1

- `third_party/libwebrtc/third_party/abseil-cpp/absl/strings/substitute.cc`
- `third_party/libwebrtc/third_party/abseil-cpp/absl/strings/escaping.cc`
- `third_party/libwebrtc/third_party/abseil-cpp/absl/strings/internal/charconv_parse.h`
- `third_party/libwebrtc/third_party/abseil-cpp/absl/strings/str_join.h`
- `third_party/libwebrtc/third_party/abseil-cpp/absl/strings/internal/charconv_bigint.h`
- `third_party/libwebrtc/third_party/abseil-cpp/absl/strings/charconv.cc`
- `third_party/libwebrtc/third_party/abseil-cpp/absl/strings/internal/escaping.h`
- `third_party/libwebrtc/third_party/abseil-cpp/absl/strings/substitute.h`
- `third_party/libwebrtc/third_party/abseil-cpp/absl/strings/internal/resize_uninitialized.h`
- `third_party/libwebrtc/third_party/abseil-cpp/absl/strings/internal/utf8.cc`
- `third_party/libwebrtc/third_party/abseil-cpp/absl/base/casts.h`
- `third_party/libwebrtc/third_party/abseil-cpp/absl/strings/numbers.h`
- `third_party/libwebrtc/third_party/abseil-cpp/absl/strings/str_cat.cc`
- `third_party/libwebrtc/third_party/abseil-cpp/absl/strings/internal/ostringstream.h`
- `third_party/libwebrtc/third_party/abseil-cpp/absl/strings/internal/utf8.h`
- `third_party/libwebrtc/third_party/abseil-cpp/absl/strings/internal/str_join_internal.h`
- `third_party/libwebrtc/third_party/abseil-cpp/absl/strings/internal/ostringstream.cc`
- `third_party/libwebrtc/third_party/abseil-cpp/absl/strings/internal/charconv_bigint.cc`
- `third_party/libwebrtc/third_party/abseil-cpp/absl/strings/internal/charconv_parse.cc`
- `third_party/libwebrtc/third_party/abseil-cpp/absl/strings/charconv.h`
- `third_party/libwebrtc/third_party/abseil-cpp/absl/base/internal/unaligned_access.h`
- `third_party/libwebrtc/third_party/abseil-cpp/absl/strings/escaping.h`
- `third_party/libwebrtc/third_party/abseil-cpp/absl/base/internal/endian.h`
- `third_party/libwebrtc/third_party/abseil-cpp/absl/strings/str_cat.h`
- `third_party/libwebrtc/third_party/abseil-cpp/absl/strings/numbers.cc`
- `third_party/libwebrtc/third_party/abseil-cpp/absl/strings/internal/escaping.cc`
- `third_party/libwebrtc/third_party/abseil-cpp/absl/strings/str_replace.cc`
- `third_party/libwebrtc/third_party/abseil-cpp/absl/strings/str_replace.h`

#### Cluster 2

- `third_party/libwebrtc/modules/audio_device/dummy/file_audio_device.h`
- `third_party/libwebrtc/rtc_base/timestamp_aligner.h`
- `third_party/libwebrtc/modules/audio_device/fine_audio_buffer.cc`
- `third_party/libwebrtc/modules/audio_device/audio_device_generic.h`
- `third_party/libwebrtc/modules/audio_device/fine_audio_buffer.h`
- `third_party/libwebrtc/modules/audio_device/dummy/audio_device_dummy.cc`
- `third_party/libwebrtc/modules/audio_device/dummy/file_audio_device.cc`
- `third_party/libwebrtc/modules/audio_device/dummy/file_audio_device_factory.cc`
- `third_party/libwebrtc/modules/audio_device/audio_device_generic.cc`
- `third_party/libwebrtc/modules/audio_device/dummy/audio_device_dummy.h`
- `third_party/libwebrtc/modules/audio_device/audio_device_buffer.h`
- `third_party/libwebrtc/rtc_base/timestamp_aligner.cc`
- `third_party/libwebrtc/modules/audio_device/audio_device_buffer.cc`
- `third_party/libwebrtc/modules/audio_device/dummy/file_audio_device_factory.h`

#### Cluster 3

- `third_party/libwebrtc/call/degraded_call.cc`
- `third_party/libwebrtc/call/simulated_packet_receiver.h`
- `third_party/libwebrtc/call/call_factory.h`
- `third_party/libwebrtc/call/simulated_network.cc`
- `third_party/libwebrtc/api/test/simulated_network.h`
- `third_party/libwebrtc/api/call/call_factory_interface.h`
- `third_party/libwebrtc/call/simulated_network.h`
- `third_party/libwebrtc/call/fake_network_pipe.cc`
- `third_party/libwebrtc/call/fake_network_pipe.h`
- `third_party/libwebrtc/call/call_factory.cc`
- `third_party/libwebrtc/call/degraded_call.h`

#### Cluster 4

- `third_party/libwebrtc/modules/video_coding/codecs/multiplex/multiplex_encoded_image_packer.cc`
- `third_party/libwebrtc/media/engine/multiplex_codec_factory.h`
- `third_party/libwebrtc/modules/video_coding/codecs/multiplex/multiplex_encoder_adapter.cc`
- `third_party/libwebrtc/modules/video_coding/codecs/multiplex/multiplex_decoder_adapter.cc`
- `third_party/libwebrtc/modules/video_coding/codecs/multiplex/include/multiplex_decoder_adapter.h`
- `third_party/libwebrtc/modules/video_coding/codecs/multiplex/include/multiplex_encoder_adapter.h`
- `third_party/libwebrtc/modules/video_coding/codecs/multiplex/include/augmented_video_frame_buffer.h`
- `third_party/libwebrtc/media/engine/multiplex_codec_factory.cc`
- `third_party/libwebrtc/modules/video_coding/codecs/multiplex/augmented_video_frame_buffer.cc`
- `third_party/libwebrtc/modules/video_coding/codecs/multiplex/multiplex_encoded_image_packer.h`

#### Cluster 5

- `third_party/libwebrtc/modules/video_coding/codecs/av1/dav1d_decoder.cc`
- `third_party/libwebrtc/media/engine/internal_decoder_factory.h`
- `third_party/libwebrtc/api/video_codecs/builtin_video_decoder_factory.cc`
- `third_party/libwebrtc/modules/video_coding/codecs/h264/h264.cc`
- `third_party/libwebrtc/modules/video_coding/codecs/h264/include/h264.h`
- `third_party/libwebrtc/modules/video_coding/codecs/av1/dav1d_decoder.h`
- `third_party/libwebrtc/media/engine/internal_decoder_factory.cc`
- `third_party/libwebrtc/api/video_codecs/builtin_video_decoder_factory.h`

#### Cluster 6

- `third_party/libwebrtc/media/engine/internal_encoder_factory.h`
- `third_party/libwebrtc/api/video_codecs/video_encoder_factory_template.h`
- `third_party/libwebrtc/api/video_codecs/video_encoder_factory_template_libvpx_vp9_adapter.h`
- `third_party/libwebrtc/media/engine/internal_encoder_factory.cc`
- `third_party/libwebrtc/api/video_codecs/video_encoder_factory_template_libvpx_vp8_adapter.h`
- `third_party/libwebrtc/api/video_codecs/builtin_video_encoder_factory.h`
- `third_party/libwebrtc/api/video_codecs/builtin_video_encoder_factory.cc`

Comment 1

[Michael Froman [:mjf]]

This is a pre-run of the changes to make sure everything still builds. https://treeherder.mozilla.org/jobs?repo=try&revision=c21077de8fda58661f494dfb867d19e277c06dd4

Comment 2

[Michael Froman [:mjf]]

Attachment: Bug 1820869 - avoid building unreachable files. r?ng!

Comment 3

[Michael Froman [:mjf]]

Attachment: Bug 1820869 - moz.build updates. r?ng!

Depends on D171922

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88b3cc6bbece
avoid building unreachable files. r=ng,webrtc-reviewers
https://hg.mozilla.org/integration/autoland/rev/828c308d92e8
moz.build updates. r=ng,webrtc-reviewers

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/88b3cc6bbece
https://hg.mozilla.org/mozilla-central/rev/828c308d92e8