1820878 - Convert toolkit/mozapps/downloads to ES modules

Status: RESOLVED FIXED

(Toolkit :: Downloads API, task, P3)

Description

[Mark Banner (:standard8)]

I'm happy to mentor work towards this bug. Please don't ask to be assigned to it, though you can say you're working on it. You'll be automatically assigned when you upload the first patches.

Here's what to do:

• Make sure you have a local build of Firefox up and running. Use these instructions if you haven't already.
  • If you need help setting up, ask in #introduction on Matrix
• Using the ESMification walkthrough as a guide:
  1. Run ./mach esmify --convert path/to/files
  2. Examine the output for any errors from ESLint and fix them.
  3. Commit the changes with a commit messages such as "Bug nnnnnn - Convert path/to/files to ES modules. r?Standard8"
  4. Next convert the imports - ./mach esmify --import . --prefix path/to/files
  5. Again, check for any errors and fix them.
  6. Run a build to check it passes.
  7. Also run ./mach eslint --fix path/to/files and check there are no raised failures
  8. Commit the changes with a commit message such as "Bug nnnnnn - Convert consumers of path/to/files to import ES modules directly. r?Standard8"
• Use moz-phab submit to submit the patches for review.

Comment 1

[Abhishek[: unavailable till 11 May]]

Attachment: Bug 1820878 - Convert toolkit/mozapps/downloads to ESmodules . r=Standard8

Depends on D172024

Comment 2

[Abhishek[: unavailable till 11 May]]

Attachment: Bug 1820878 - Convert toolkit/mozapps/downloads to ESmodules . r=Standard8

Depends on D172049

Comment 3

[Abhishek[: unavailable till 11 May]]

Attachment: Bug 1820878 - Convert toolkit/mozapps/downloads to ESmodules . r=Standard8

Depends on D172050

Comment 4

[Abhishek[: unavailable till 11 May]]

I have made all the changes, but I still think it requires some changes. I will work on them, and the number of commits is high because the error becomes visible only after making the commits, so please don't mind.
Thanks

Comment 5

[Abhishek[: unavailable till 11 May]]

I have deleted the file I was working on, so I am making a new patch for it. Thanks

Comment 6

[Abhishek[: unavailable till 11 May]]

Attachment: Bug 1820878 - Convert toolkit/mozapps/downloads to ESmodules . r=Standard8!

Comment 7

[Mark Banner (:standard8)]

Hi Abhishek, are you still working on this? If you need help with the rebase, please ask in #introduction on Matrix.

Comment 8

[Abhishek[: unavailable till 11 May]]

I apologize for the delay in getting back to you. Last week, I was mostly inactive due to my exam in Infrastructure Economics, which took place today. (https://onlinecourses.nptel.ac.in/noc23_mg25/announcements?force=true) Now that the exam is over, I am available and will be able to handle this issue promptly. Thank you for your understanding.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e9a3651b0969
Convert toolkit/mozapps/downloads to ESmodules . r=Standard8,extension-reviewers,application-update-reviewers,bytesized,robwu

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/e9a3651b0969