1820880 - Convert toolkit/mozapps/update to ES modules

Status: RESOLVED FIXED

(Toolkit :: Application Update, task, P3)

Description

[Mark Banner (:standard8)]

I'm happy to mentor work towards this bug. Please don't ask to be assigned to it, though you can say you're working on it. You'll be automatically assigned when you upload the first patches.

Here's what to do:

• Make sure you have a local build of Firefox up and running. Use these instructions if you haven't already.
  • If you need help setting up, ask in #introduction on Matrix
• Using the ESMification walkthrough as a guide:
  1. Run ./mach esmify --convert path/to/files
  2. Examine the output for any errors from ESLint and fix them.
  3. Commit the changes with a commit messages such as "Bug nnnnnn - Convert path/to/files to ES modules. r?Standard8"
  4. Next convert the imports - ./mach esmify --import . --prefix path/to/files
  5. Again, check for any errors and fix them.
  6. Run a build to check it passes.
  7. Also run ./mach eslint --fix path/to/files and check there are no raised failures
  8. Commit the changes with a commit message such as "Bug nnnnnn - Convert consumers of path/to/files to import ES modules directly. r?Standard8"
• Use moz-phab submit to submit the patches for review.

Comment 1

[Leila Kaltouma]

Hi, I am Leila kaltouma, an Outreachy applicant. I'm currently working on this bug. Thank you for offering to mentor.

Comment 2

[Siya]

Hey. I'm Siya, an Outreachy applicant. I would like to work on this issue and am currently working on it.

Comment 3

[Mark Banner (:standard8)]

(In reply to Siya from comment #2)

Hey. I'm Siya, an Outreachy applicant. I would like to work on this issue and am currently working on it.

Hi Siya, please Leila a chance to put up the patch as they commented first. There should be other bugs around and available (I'll probably also be filing more bugs later).

Comment 4

[yusufjakada5]

Hello Mark. My name is Yusuf, and i am also an outreachy applicant participating for outreachy internship. I would like to be assigned to work for the upcoming bugs.

Comment 5

[yusufjakada5]

And can i also be assigned to work on this issue?

Comment 6

[Mark Banner (:standard8)]

(In reply to yusufjakada5 from comment #5)

And can i also be assigned to work on this issue?

Please make sure you read the previous comments when commenting on bugs. As you'll see Leila is already working on this, and I have already suggested to Siya that they find a different bug.

Comment 7

[Leila Kaltouma]

Attachment: Bug 1820880 - Convert toolkit/mozapps/update to ES modules. r?Standard8

Comment 8

[Leila Kaltouma]

Attachment: Bug 1820880 - Convert toolkit/mozapps/update to import ES modules directly. r?Standard8

Depends on D172120

Comment 9

[Leila Kaltouma]

Thank you for assigning this task to me.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8da6d504d011
Convert toolkit/mozapps/update to ES modules. r=Standard8,application-update-reviewers,bytesized,nalexander
https://hg.mozilla.org/integration/autoland/rev/190fed1de1bf
Convert toolkit/mozapps/update to import ES modules directly. r=Standard8,settings-reviewers,application-update-reviewers,bytesized

Comment 11

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/8da6d504d011
https://hg.mozilla.org/mozilla-central/rev/190fed1de1bf