1820913 - Expose missing features in GfxInfo::DescribeFeatures

Status: ASSIGNED

(Core :: Graphics, task, P3)

Description

[Andrew Osmond [:aosmond] (he/him)]

We only expose a few features through GfxInfo::DescribeFeatures:
https://searchfox.org/mozilla-central/rev/416f31a51174620f04fc994d248b664b54517699/widget/GfxInfoBase.cpp#1741

This seems to just be an oversight, and the data could be useful when analyzing crash reports or performing queries on our telemetry base about the feature status.

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1820913 - Expose missing features in GfxInfo::DescribeFeatures.

This patch expands the graphics features exposed in
GfxInfo::DescribeFeatures to include the many new features added since
WebRender has shipped. This data will be included in crash reports and
telemetry which should prove useful for future analysis.

Comment 2

[Darkspirit]

windowProtocol (x11 vs. xwayland vs. wayland) might be interesting as well, it's missing on crash-stats.

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

(In reply to Darkspirit from comment #2)

windowProtocol (x11 vs. xwayland vs. wayland) might be interesting as well, it's missing on crash-stats.

IsWayland is included in crash stats but maybe you need more privileged access to see it. I imagine that could be open to the public if so...

Comment 4

[Darkspirit]

IIRC (I could be wrong), some older Nvidia drivers that only support EGLStreams instead of Gbm crash only in Xwayland. Not Wayland, not X11.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:aosmond, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.