1820951 - Revisit DevToolsUtils.hasSafeGetter condition

Status: RESOLVED FIXED

(DevTools :: General, task)

Description

[Tooru Fujisawa [:arai]]

DevToolsUtils.hasSafeGetter seems to assume that the getter with native function is "safe"

https://searchfox.org/mozilla-central/rev/3002762e41363de8ee9ca80196d55e79651bcb6b/devtools/shared/DevToolsUtils.js#269-277,282

/**
 * Determines if a descriptor has a getter which doesn't call into JavaScript.
 *
 * @param Object desc
 *        The descriptor to check for a safe getter.
 * @return Boolean
 *         Whether a safe getter was found.
 */
exports.hasSafeGetter = function(desc) {
...
  return fn?.callable && fn?.class == "Function" && fn?.script === undefined;

bug 1806598 changed the other place not to assume native getter is safe,
and also bug 1805288 is going to change XPCOMUtils.defineLazyGetter to use native function.

DevToolsUtils.hasSafeGetter should be updated to follow the changes.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1820951 - Part 1: Implement DevToolsUtils.hasSafeGetter based on explicit allowlist and DebuggerObject.prototype.isNativeGetterWithJitInfo. r?nchevobbe!

Depends on D175092

Comment 2

[Nicolas Chevobbe [:nchevobbe][PTO - back on October 21]]

Thanks a lot for taking care of this
It makes a lot of sense to share the same pattern between eager evaluation and "safe getters" in object preview

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1820951 - Part 2: Add tests. r?nchevobbe!

Depends on D175093

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f86da5e77878
Part 1: Implement DevToolsUtils.hasSafeGetter based on explicit allowlist and DebuggerObject.prototype.isNativeGetterWithJitInfo. r=nchevobbe,devtools-reviewers
https://hg.mozilla.org/integration/autoland/rev/cb3f2eb3e0db
Part 2: Add tests. r=nchevobbe,devtools-reviewers

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/f86da5e77878
https://hg.mozilla.org/mozilla-central/rev/cb3f2eb3e0db