1821021 - MessageNotificationWorker is not working as expected

Status: RESOLVED FIXED

(Fenix :: Experimentation and Telemetry, defect)

Description

[twhite]

QA have been unable to reliably validate the Messaging notification with the given constraints. Investigation has identified that the periodic worker configuration used by the Messaging Notification Worker is not working as expected.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

https://github.com/mozilla-mobile/firefox-android/commit/aa38199f4ef70699e1c73e39ddc4f443a57a857a
https://github.com/mozilla-mobile/firefox-android/commit/806c1689165be927fb6c26b422c2262cde18f37a
https://github.com/mozilla-mobile/firefox-android/commit/6467acc42c1e55d0792b95d842c1fdcdf1ba55ce

Comment 2

[Chris Peterson [:cpeterson]]

(In reply to twhite from comment #0)

QA have been unable to reliably validate the Messaging notification with the given constraints. Investigation has identified that the periodic worker configuration used by the Messaging Notification Worker is not working as expected.

Tom, does your fix need to be uplifted to a 111 dot release for any Messaging Notifications planned for 111? Or can your fix ride the trains with 112?

Comment 3

[twhite]

[:cpeterson] this is currently being discussed

Comment 4

[Chris Peterson [:cpeterson]]

Channing says we don't need to uplift this fix to a 111 dot release. It can ship in 112.

Comment 5

[Jonathan Almeida [:jonalmeida]]

(In reply to twhite from comment #0)

QA have been unable to reliably validate the Messaging notification with the given constraints. Investigation has identified that the periodic worker configuration used by the Messaging Notification Worker is not working as expected.

Tom, Alex is looking to land a change that moves SharedIds.getIdForTag off the main thread, and this change here has removed the IO scope that would have been used to do this work off the main thread.

Could you share some more information on what is not working as expected so that we avoid regressing any of your fixes?

Comment 6

[twhite]

[:jonalmeida] sure. We updated how the MessageNotificationWorker doWork() calls async funcs based on the doc in Worker.doWork()

This method is called on a background thread - you are required to synchronously do your work and return the ListenableWorker.Result from this method.

There were multiple causes to the original intermittent failure of the notification being triggered - Although not explicitly tested in isolation, it's possible our use of IO scope was one of them.