1821025 - Perma TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/wasm/features.js | /builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/features.js:90:13 Error: Assertion failed: got false, expected true: when Gecko 112 merges to Beta on 2023-03-13

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Serban Stanca [:SerbanS]]

Central-as-beta-simulation

How to run these simulations

Failure log

[task 2023-03-08T10:59:59.564Z] TEST-PASS | js/src/jit-test/tests/wasm/fac.js | Success (code 0, args "--test-wasm-await-tier2") [0.1 s]
[task 2023-03-08T10:59:59.580Z] /builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/features.js:90:13 Error: Assertion failed: got false, expected true: extended-const must be enabled on release and beta
[task 2023-03-08T10:59:59.580Z] Stack:
[task 2023-03-08T10:59:59.580Z]   @/builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/features.js:90:13
[task 2023-03-08T10:59:59.580Z] Exit code: 3
[task 2023-03-08T10:59:59.580Z] FAIL - wasm/features.js
[task 2023-03-08T10:59:59.581Z] TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/wasm/features.js | /builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/features.js:90:13 Error: Assertion failed: got false, expected true: extended-const must be enabled on release and beta (code 3, args "") [0.1 s]
[task 2023-03-08T10:59:59.581Z] INFO exit-status     : 3
[task 2023-03-08T10:59:59.581Z] INFO timed-out       : False
[task 2023-03-08T10:59:59.581Z] INFO stderr         2> /builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/features.js:90:13 Error: Assertion failed: got false, expected true: extended-const must be enabled on release and beta
[task 2023-03-08T10:59:59.581Z] INFO stderr         2> Stack:
[task 2023-03-08T10:59:59.581Z] INFO stderr         2> @/builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/features.js:90:13
[task 2023-03-08T10:59:59.612Z] TEST-PASS | js/src/jit-test/tests/wasm/fac.js | Success (code 0, args "--wasm-compiler=optimizing --no-avx") [0.1 s]
[task 2023-03-08T10:59:59.638Z] /builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/features.js:90:13 Error: Assertion failed: got false, expected true: extended-const must be enabled on release and beta
[task 2023-03-08T10:59:59.638Z] Stack:
[task 2023-03-08T10:59:59.639Z]   @/builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/features.js:90:13
[task 2023-03-08T10:59:59.639Z] Exit code: 3
[task 2023-03-08T10:59:59.639Z] FAIL - wasm/features.js
[task 2023-03-08T10:59:59.648Z] TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/wasm/features.js | /builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/features.js:90:13 Error: Assertion failed: got false, expected true: extended-const must be enabled on release and beta (code 3, args "--baseline-eager") [0.1 s]
[task 2023-03-08T10:59:59.649Z] INFO exit-status     : 3
[task 2023-03-08T10:59:59.649Z] INFO timed-out       : False
[task 2023-03-08T10:59:59.649Z] INFO stderr         2> /builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/features.js:90:13 Error: Assertion failed: got false, expected true: extended-const must be enabled on release and beta
[task 2023-03-08T10:59:59.649Z] INFO stderr         2> Stack:
[task 2023-03-08T10:59:59.649Z] INFO stderr         2> @/builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/features.js:90:13
[task 2023-03-08T10:59:59.652Z] /builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/features.js:90:13 Error: Assertion failed: got false, expected true: extended-const must be enabled on release and beta
[task 2023-03-08T10:59:59.653Z] Stack:
[task 2023-03-08T10:59:59.653Z]   @/builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/features.js:90:13
[task 2023-03-08T10:59:59.653Z] Exit code: 3
[task 2023-03-08T10:59:59.653Z] FAIL - wasm/features.js
[task 2023-03-08T10:59:59.654Z] TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/wasm/features.js | /builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/features.js:90:13 Error: Assertion failed: got false, expected true: extended-const must be enabled on release and beta (code 3, args "--ion-eager --ion-offthread-compile=off --ion-check-range-analysis --ion-extra-checks --no-sse3 --no-threads") [0.1 s]
[task 2023-03-08T10:59:59.654Z] INFO exit-status     : 3
[task 2023-03-08T10:59:59.654Z] INFO timed-out       : False
[task 2023-03-08T10:59:59.655Z] INFO stderr         2> /builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/features.js:90:13 Error: Assertion failed: got false, expected true: extended-const must be enabled on release and beta
[task 2023-03-08T10:59:59.655Z] INFO stderr         2> Stack:
[task 2023-03-08T10:59:59.655Z] INFO stderr         2> @/builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/features.js:90:13
[task 2023-03-08T10:59:59.655Z] /builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/features.js:90:13 Error: Assertion failed: got false, expected true: extended-const must be enabled on release and beta
[task 2023-03-08T10:59:59.656Z] Stack:
[task 2023-03-08T10:59:59.656Z]   @/builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/features.js:90:13
[task 2023-03-08T10:59:59.656Z] Exit code: 3

Comment 1

[Ben Visness [:bvisness]]

Attachment: Bug 1821025: Unconditionally enable wasm extended-const. r=rhunt

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/074a234d6779
Unconditionally enable wasm extended-const. r=rhunt

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/074a234d6779

Comment 4

[Cristian Tuns]

The patch is not working: https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&revision=49b4bd78911c514c57759e31528a855bd7b152ff&searchStr=sm&selectedTaskRun=DlH8Bni2SyysFgsbk6JnLg.0 can you please take another look?
Or it worked but just on the tier 1 jobs, now we still have the tier 2:

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

wasm-no-experimental runs as tier 2 and no other tasks are broken in the central-as-beta simulation are broken - this should not block the central to beta merge on Monday.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1814421

Comment 7

[Ben Visness [:bvisness]]

Attachment: Bug 1821025: Remove extended-const from wasm-no-experimental. r=rhunt

Comment 8

[Iulian Moraru]

The latest patch seems to be working on today's central as early beta simulation.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/69fd25a4b45b
Remove extended-const from wasm-no-experimental. r=rhunt

Comment 10

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/69fd25a4b45b

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:bvisness, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox112 to wontfix.

For more information, please visit auto_nag documentation.

Comment 12

[Ryan Hunt [:rhunt] (on leave until early May)]

Comment on attachment 9324210 [details]
Bug 1821025: Remove extended-const from wasm-no-experimental. r=rhunt

Beta/Release Uplift Approval Request

• User impact if declined: No user impact. This will fix a tier2 try job, and could be useful for release management to have greener try runs.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This fixes a tier2 try job by getting the right configure flags for it when it's built. This won't affect normal builds.
• String changes made/needed:
• Is Android affected?: Yes

Comment 13

[Dianna Smith [:diannaS]]

Comment on attachment 9324210 [details]
Bug 1821025: Remove extended-const from wasm-no-experimental. r=rhunt

Approved for 112.0b6

Comment 14

[Dianna Smith [:diannaS]]

Comment on attachment 9321908 [details]
Bug 1821025: Unconditionally enable wasm extended-const. r=rhunt

this is already in fx112

Comment 15

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e96e8d723672

Comment 16

[Norisz Fay [:noriszfay]]

Verified fixed in this central as beta simulation