1821042 - The Clear now button from the Clear Recent history panel will not disable if we uncheck the Browsing and Download history option

Status: VERIFIED FIXED

(Toolkit :: Data Sanitization, defect)

Description

[Rares Doghi, Desktop QA]

Attachment: 2023-03-08_15h03_01.mp4

Found in

• 112.0a1 (2023-03-07)

Affected versions

• Beta 111.0b9
• 102.9.0esr
• Release 110

Affected platforms

• ALL

Steps to reproduce

1. Have only the Browsing and Download History option checked in the Clear Recent History panel.
2. Uncheck the Browsing and Download History option from the Panel.

Expected result

• The Clear Now button should be disabled after unchecking the last option.

Actual result

• Unchecking the Browsing and Download History option will not disable the Clear now button.

Regression range
6:28.27 INFO: Last good revision: df251f2e0320157d444a0e8e5e609f3bc1969f57 (2020-04-26)
6:28.27 INFO: First bad revision: 2b0e2483e2eaaef7ac49866a98e8e857520bdd5c (2020-04-27)
6:28.27 INFO: Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=df251f2e0320157d444a0e8e5e609f3bc1969f57&tochange=2b0e2483e2eaaef7ac49866a98e8e857520bdd5c

Please note that if any other last option is unchecked the Clear now button will immediately disable.
Also if the Browsing and Download History option was already unchecked when the Clear Recent History panel was opened, Checking and unchecking that option will disable the Clear now buttton.

Comment 1

[Alice0775 White]

I can reproduce this on Nightly112.0a1 Windows10.

Regression window(from local cache):
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=dc41492033491f409344d26684c2de16db767900&tochange=6527df70a124cf5bc6d91bc40820da1ce0456cee

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:mkaply, since you are the author of the regressor, bug 1557754, could you take a look?

For more information, please visit auto_nag documentation.

Comment 3

[Mike Kaply [:mkaply]]

I'm not 100% convinced this is related to my work, but it's definitely a bug and I have a sense of what's going on.

The issue is specifically the Browsing & Download History checkbox.

While that checkbox internally affects two values (privacy.cpd.history and privacy.cpd.downloads), when the checkbox is unchecked, it only immediately affects privacy.cpd.history. So when onReadGeneric is called, privacy.cpd.downloads is still true and so the button is not disabled.

Comment 4

[Mike Kaply [:mkaply]]

Attachment: Bug 1821042 - Downloads pref shouldn't impact enablement of sanitize dialog. r?Gijs

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4637d7a67afa
Downloads pref shouldn't impact enablement of sanitize dialog. r=hpeuckmann

Comment 6

[Atila Butkovits]

Backed out for causing failures at browser_sanitizeDialog.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/8924e731b5b206d553e5eaddac967b98f3b6de9c

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=eAJWmVLeTj-BDHwNF7z55A.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=4637d7a67afaa483c370da429c8f57fa196cb57f

Failure log: https://treeherder.mozilla.org/logviewer?job_id=408735484&repo=autoland&lineNumber=4625

Comment 7

[Norisz Fay [:noriszfay]]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/8924e731b5b2

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1557754

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d39c247adcff
Downloads pref shouldn't impact enablement of sanitize dialog. r=hpeuckmann

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/d39c247adcff

Comment 11

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Nightly 113.0a1 (2023-03-15).

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mkaply, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox112 to wontfix.

For more information, please visit auto_nag documentation.

Comment 13

[Rares Doghi, Desktop QA]

Updating the main status flag.