1821065 - [PL][x-kom]Form preview/autofill/clear not applied in the eligible fields

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, defect, P2)

Description

[Ina Popescu, Desktop QA]

Attachment: x-kom_no dropdown, no preview, no autofill.mp4

Found in

• Firefox 111

Affected versions

• Firefox 111

Tested platforms

• Affected platforms: Windows 10

Preconditions

• set pref extensions.formautofill.creditCards.supportedCountries to IT,ES,PL,AT,BE in about:config
• set pref browser.search.region to PL in about:config
• use PL VPN
• have several credit cards saved in about:preferences#privacy

Steps to reproduce

1. Go to https://www.x-kom.pl/
2. Add an item to cart and proceed to checkout
3. Reach the payment page
4. Click in either the Card Number field

Expected result

• Form preview/autofill/clear should be applied in the eligible fields.

Actual result

• Form preview/autofill/clear is not applied in the eligible fields.

Regression range

• Not a regression because this feature is disabled by default.

Additional notes

• The issue is not reproduceable in Google Chrome.
• Fathom Fox downloaded page: https://drive.google.com/file/d/1SZHLujK2LtqEor-TY6J1MwXtjxmCCOYe/view?usp=sharing

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:epopescu, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Dimi Lee [:dimi]]

This can be fixed by adding
(numer).*(karty) to cc-number regexp and data.*ważności to cc-exp regexp

Comment 3

[Dimi Lee [:dimi]]

Attachment: Bug 1821065 - Add expiration date related polish keywords r=#credential-management-reviewers,mtigley

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/44dbcc48482e
Add expiration date related polish keywords r=mtigley,credential-management-reviewers,sgalich

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/44dbcc48482e

Comment 7

[Ina Popescu, Desktop QA]

Attachment: 2023-05-23_www.x-kom.pl.mp4

I'm still able to reproduce this issue in the latest Nightly 115.0a1 (2023-05-23).
Please see the attachment.
Saved page: https://drive.google.com/drive/folders/1Y4SLUsUgfigAjZUSVZY43_Ltp8KUAPvu

Comment 8

[Dimi Lee [:dimi]]

Attachment: Bug 1821065 - Sync the label matching heuristics for js and native implementation. r=#credential-management-reviewers

In the label matching heuristic, we should not bail out when there is
no label. See
https://searchfox.org/mozilla-central/rev/d307d4d9f06dab6d16e963a4318e5e8ff4899141/toolkit/components/formautofill/shared/CreditCardRuleset.sys.mjs#418-423

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/51d33b3b5fd3
Sync the label matching heuristics for js and native implementation. r=credential-management-reviewers,sgalich

Comment 10

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/51d33b3b5fd3

Comment 11

[Ina Popescu, Desktop QA]

Verified as fixed in the latest Nightly 116.0a1 (2023-07-03) version where the issue no longer persists.
However the eligible fields are not highlighted when previewed or autofilled. For this issue I've filed Bug 1841529. Thanks.