1821092 - Support localized experiments in Nimbus

Status: RESOLVED FIXED

(Firefox :: Nimbus Desktop Client, task, P1)

Description

[Beth Rennie [:beth] (she/her)]

From the proposal:

The desktop client implementation will add support for the new localizations field. When a consumer requests a feature variable from the Nimbus API, if the experiment is localized and that variable references a string name, it will return the localized value for that string name in the user's locale. This process will be transparent to the client: it will not be aware that the string is localized or that there are other possible localizations.

When applying schema validation, the validation must occur after doing variable substitution due to strings being replaced by objects containing the localization data. For example, some fields may expect to be formatted as URI and so would fail validation if their content was an unevaluated reference to a string name.

Desktop will only perform schema validation with the substitution that matches its locale.

Comment 1

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1821092 - Update nimbus-shared to 2.0.0 r?emcminn,aminomancer

Comment 2

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1821092 - Implment localization substitution for Nimbus Experiments r?emcminn,aminomancer

Depends on D174548

Comment 3

[Beth Rennie [:beth] (she/her)]

Attachment: data-review-1821092.md

Comment 4

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1821092 - Enroll in localized Nimbus experiments r?emcminn,aminomancer

Depends on D174549

Comment 5

[Chris H-C :chutten]

Comment on attachment 9326952 [details]
data-review-1821092.md

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Barret Rennie is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

---

Result: datareview+

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b70d97b262ed
Update nimbus-shared to 2.0.0 r=aminomancer
https://hg.mozilla.org/integration/autoland/rev/ff07a826e81d
Implment localization substitution for Nimbus Experiments r=aminomancer
https://hg.mozilla.org/integration/autoland/rev/142e58fc3ee1
Enroll in localized Nimbus experiments r=aminomancer

Comment 7

[Noemi Erli[:noemi_erli]]

Backed out 3 changesets (Bug 1821092) for causing failures in browser_autocomplete_import.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=YoWYe8o9RPO0ULXeautowA.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=142e58fc3ee1c0f747218aa5bc5eee32efa26193

Log: https://treeherder.mozilla.org/logviewer?job_id=411555014&repo=autoland&lineNumber=4560

Backout: https://hg.mozilla.org/integration/autoland/rev/66cb126021729400805860113e05e217c04df02d

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6bac5dd3e5f5
Update nimbus-shared to 2.0.0 r=aminomancer
https://hg.mozilla.org/integration/autoland/rev/37a96a543ee9
Implment localization substitution for Nimbus Experiments r=aminomancer,credential-management-reviewers,sgalich
https://hg.mozilla.org/integration/autoland/rev/931d7c23ca70
Enroll in localized Nimbus experiments r=aminomancer

Comment 9

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/6bac5dd3e5f5
https://hg.mozilla.org/mozilla-central/rev/37a96a543ee9
https://hg.mozilla.org/mozilla-central/rev/931d7c23ca70

Comment 10

[Beth Rennie [:beth] (she/her)]

Comment on attachment 9326760 [details]
Bug 1821092 - Implment localization substitution for Nimbus Experiments r?emcminn,aminomancer

Beta/Release Uplift Approval Request

• User impact if declined: We will not be able to run localized experiments in 113
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The schema change is harmless.
  The code changes only take effect for localized experiments. If we do not launch any localized experiments, users will not see anything.

Localized experiments will be QA'd internally for correctness before launching to the public.

• String changes made/needed:
• Is Android affected?: No

Comment 11

[Pascal Chevrel:pascalc]

Comment on attachment 9326760 [details]
Bug 1821092 - Implment localization substitution for Nimbus Experiments r?emcminn,aminomancer

Approved for 113 beta 3, thanks.

Comment 12

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/68ed0f5f5c2f
https://hg.mozilla.org/releases/mozilla-beta/rev/2a6c2153d3a6
https://hg.mozilla.org/releases/mozilla-beta/rev/f8d9bba4c6ad