QuickSuggest may be bypassing maxRichResults?
Categories
(Firefox :: Address Bar, defect, P3)
Tracking
()
People
(Reporter: mak, Assigned: adw)
References
Details
(Keywords: privacy, Whiteboard: [snt-scrubbed][search-privacy])
Attachments
(2 files)
screenshot_2023-03-08_at_11.36.22_am.png
We were debugging a case where an employee was getting no results from the urlbar today, and we discovered the problem was maxRichResults being set to 0.
Though one of the screenshots clearly showed a QuickSuggest Wikipedia result, that should not have been there.
about:studies didn't show anything active.
|
Assignee | |
Comment 1•1 year ago
|
||
The problem is here, when the muxer adds group-relative suggested-index results, which quick suggest results are. I don't remember if it was intentional or not -- I don't think so. The muxer always adds these results even if availableSpan and/or maxResultCount aren't sufficient.
|
||
Updated•1 year ago
|
|
||
Updated•1 year ago
|
|
|
||
Updated•1 year ago
|
|
|
Assignee | |
Updated•5 months ago
|
|
|
Assignee | |
Comment 2•5 months ago
|
||
Pushed by dwillcoxon@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/106f09ba0e1b Make the urlbar muxer take span and count limits into account when adding suggested-index results. r=mak
|
||
Comment 4•5 months ago
|
||
| bugherder | ||
|
||
Comment 5•4 months ago
|
||
Reproducible on a 2023-03-08 Nightly build on Windows 10.
Verified as fixed on Firefox 122.0 and Nightly 123.0a1 on Windows 10, Ubuntu 22, macOS 12.
With maxRichResults set to 0 and QuickSuggest prefs set to true, there are no suggestions in the address bar.
Description
•