1821133 - [wpt-sync] Sync PR 38892 - VT: Be resilient if there is no documentElement().

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 38892 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/38892
Details from upstream follow.

Vladimir Levin <[e-mail]> wrote:

VT: Be resilient if there is no documentElement().

This patch updates all of the places where we access documentElement()
to make sure it either is there (via DCHECKs) or gate access
conditionally.

This is to address the referenced clusterfuzz. I can't repro this
locally, but it is clearly an access into a documentElement() when it's
null.

Since we can handle the null situations gracefully in all cases, this
is just an improvement to the robustness of the code.

R=[e-mail]

Bug: 1413903
Change-Id: I1b81e36a2b88291e364407241c3b0fd0c34de252
Reviewed-on: https://chromium-review.googlesource.com/4317782
WPT-Export-Revision: 4ff0022f077a9f4a78a05a9161add7f7d5890555

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=7965edbd04014f8ca9486b030bd8a7a692a6ad1f

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS : 1

Chrome

CRASH: 1

Safari

PASS : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/049c1a1c5470
[wpt PR 38892] - VT: Be resilient if there is no documentElement()., a=testonly

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/049c1a1c5470