1821146 - Crashes due to using a cycle-collected object on a thread that isn't cycle collected in WebTransport

Status: RESOLVED FIXED

(Core :: DOM: Networking, defect, P2)

Description

[Randell Jesup [:jesup] (needinfo me)]

This is caused by calling Bind(endpoint) without passing a thread target if we're on a worker, which targets the worker thread, and not the correct event target for the worker.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1821146: Bind() IPC to worker's event target for WebTransport r=asuth,nika

Also fixes the worker shutdown handling associated with this

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/889174ce36fd
Bind() IPC to worker's event target for WebTransport r=asuth

Comment 3

[Cristian Tuns]

Backed out for causing build bustages on WebTransportDatagramDuplexStream.cpp

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/workspace/obj-build/dist/include/mozilla/dom/Promise.h:300:33: error: function 'mozilla::dom::Promise::ThenWithCycleCollectedArgs<(lambda at /builds/worker/checkouts/gecko/dom/webtransport/api/WebTransportDatagramDuplexStream.cpp:190:13), RefPtr<mozilla::dom::IncomingDatagramStreamAlgorithms> &, RefPtr<mozilla::dom::Promise> &>' is used but not defined in this translation unit, and cannot be defined in any other translation unit

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/204fead3800d
Bind() IPC to worker's event target for WebTransport r=asuth

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/204fead3800d