1821175 - Push comment support is too strict when validating JSON data from Github and throwing error when sending event

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: API, defect)

Description

[David Lawrence [:dkl]]

{"code":32000,"documentation":"https:\/\/bmo.readthedocs.io\/en\/latest\/api\/","error":1,"message":"The following errors occurred when validating input data: Properties\nnot allowed: added, committer, distinct, id, modified, removed,\ntimestamp, tree_id. => \/commits\/0"}

Need to remove the ->strict portion of https://github.com/mozilla-bteam/bmo/blob/master/Bugzilla/API/V1/Github.pm#L210

Should not have been there and my tests didn't pick it up since they only use exact data in the JSON used for testing :( Will fix that as well.

Comment 1

[BMO Automation]

Attachment: [mozilla-bteam/bmo] Bug 1821175 - Push comment support is too strict when validating JSON data from Github and throwing error when sending event (#2026)

Comment 2

[David Lawrence [:dkl]]

Merged
https://github.com/mozilla-bteam/bmo/commit/003a050f1b79d9d30bad7dfac103909e3975dc15