1821185 - [hazards] Improve the cut & paste command lines for running individual steps

Status: RESOLVED FIXED

(Core :: JavaScript: GC, enhancement, P2)

Description

[Steve Fink [:sfink] [:s:]]

This has no effect on the actual analysis, but my debugging routine for problems is to run mach hazards analyze, then scroll back up through the output and cut & paste in a command line, eg:

XDB="$HOME/.mozbuild/hazard-tools/sixgill/usr/bin/xdb.so" SOURCE="$HOME/src/mozilla3/js/src/devtools/rootAnalysis/t/types" ~/src/mozilla3/obj-haz-shell/dist/bin/js ~/src/mozilla3/js/src/devtools/rootAnalysis/analyzeRoots.js gcFunctions.lst limitedFunctions.lst gcTypes.txt typeInfo.txt 1 16 tmp.1.of.16 > rootingHazards.1.of.1

I have a script debug that if I prefix the above with debug --js, it will run the script under the JS debugger. Additionally, most commands accept a --function "$SOMEFUNC" argument to only process a single function. Both are invaluable for getting into the debugger close to the stuff I need to look at.

There are two problems. First, the commands often have extra parameters that are only there to speed up the execution by parallelizing some steps. The above command will only process 1/16 of the total functions, and if the function I am interested in is not in that slice, I'm out of luck. Right now, I manually remove those parameters (since the default is to run on the whole set.)

Second, the output is way too verbose, so it is very hard to find the right output line. Most of the output is useless most of the time. It would be better to have more verbosity levels and default to something less verbose, and to trim down the output that I do care about so I don't have to cut & paste across 20 lines. (The above example is shorter than the reality.)

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1821185 - [hazards] Cut down the default output dramatically, to make it easier to find what to debug.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:sfink, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae73000f2b8a
[hazards] Cut down the default output dramatically, to make it easier to find what to debug. r=bthrall

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/ae73000f2b8a