1821191 - Document the "destructive" button variant in Storybook

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task)

Description

[Hanna Jones [:hjones]]

Attachment: Example of a destructive button in about:logins

We support a red "destructive" button variant via the .danger-button class. This variant isn't very widely used, should still be documented alongside the other buttons in Storybook.

To work effectively on this bug, you'll need to get Storybook running locally. Instructions for how to do that can be found here.

Once you have Storybook up and running, take a look at this code in button.stories.mjs. What we want to do is add a DestructiveButton or DangerButton story where the "danger-button" class gets added here.

If you're a contributor who hasn't worked with Storybook or Lit before and you're wondering what's going on here it might be helpful to familiarize yourself with the documentation for those libraries before starting this task.

Comment 1

[Adepeju Orefejo]

I want to work on this. I am already looking into it.

Comment 2

[Hanna Jones [:hjones]]

Hey, that's great. I'll assign this bug to you for now while you look into it. If you run into issues or have any questions you can use the form below to request information from me, or reach out to me and my teammates in the #reusable-components channel on Matrix.

Comment 3

[Adepeju Orefejo]

thank you!

Comment 4

[Adepeju Orefejo]

Hi, i have completed the task and committed my changes with hg commit. Is there anything else i have to do to get my changes to you?

Comment 5

[Hanna Jones [:hjones]]

Hey - so the next step is to run moz-phab submit to submit your code for review. You can take a look at this guide to make sure that your commit message is referencing the bug number and following our other conventions (you can omit the [devtools] from the message, but otherwise everything in that document applies here). Thanks!

Comment 6

[Hanna Jones [:hjones]]

Hey Adepeju Orefejo are you still planning on submitting your code for review? If not I may open this bug up again so another Outreachy applicant can try to fix it. Let me know if you're still working on it and if you need any help!

Comment 7

[Lata]

hey Hanna! Can I work on this bug? The bug I am working on is in review and discussion. They might take more time. In the meanwhile, can I work on this? Otherwise, if there are any open bugs that need attention, I would be happy to take a look and see if I can help.

Comment 8

[Lata]

Hey Hanna! I am not actively working on any other bug, Can I work on this?

Comment 9

[Hanna Jones [:hjones]]

Hey Lata feel free to take a look and submit a patch if you think you have a fix for this.

Just a note - if you want information from someone you can use the "Request information from" inputs at the bottom of this form. People won't always see comments and are more likely to respond to needinfo requests.

Comment 10

[Lata]

Okay Hanna! Thanks. I'm working on this.

Comment 11

[Lata]

Attachment: Bug 1821191 - Document the destructive button variant in storybook. r=hjones!

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a6b031d37d4
Document the destructive button variant in storybook. r=hjones

Comment 13

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/8a6b031d37d4