standardize manifest conditions for OS/platform
Categories
(Testing :: General, task)
Tracking
(Not tracked)
People
(Reporter: jmaher, Unassigned)
References
(Blocks 1 open bug)
Details
currently we use a variety of methods for skip-if, and we should standardize on these.
This bug will be to edit all the .ini (or .toml if migrated) to use simple options for OS:
win7 (to define)
win10_2004
win11_2009
apple_silicon
apple_catalina
android13 (to define)
android9 (to define -emulator)
linux_1804 (to define)
linux_2204 (to define)
no more need for os == '...' or toolkit == '...'
the advantage of this is when we migrate to a new platform, we get the opportunity to revisit the tests. For example when migrating from win10 -> win11, if a test is skipped with skip-if = os == "win", then we never run it on win11; but if it was skipped with skip-if = win10_2004, then it would run (and either fail or pass) on win11. In fact many tests do pass, and we get a larger set of tests expected pass.
|
Reporter | |
Comment 1•1 year ago
|
||
some people do not like the hardcoded variables and would prefer the os == linux && os_version == '22.04', I think that is ok, but this bug should work towards removing the blanket:
skip-if = os == 'linux'
that almost guarantees we will never revisit this test.
|
|
Reporter | |
Comment 2•1 year ago
|
||
I think a win here is adding a linter that ensures new lines in a skip-if have both os and os_version
Description
•