Closed Bug 1821354 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 38905 - Trim whitespace around CSS custom declarations.

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
113 Branch
Tracking Flags:
Tracking Status
firefox113 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 38905 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/38905
Details from upstream follow.

Steinar H. Gunderson <sesse@chromium.org> wrote:

Trim whitespace around CSS custom declarations.

There was a spec change a few years back, requiring us to
strip spaces and comments from the beginning and end of CSS
custom property declarations.

TODO: should we do something about setProperty()? (right now, it strips)

Fixed: 1211112
Fixed: 1220144
Change-Id: Ib7656de36d6a94d85ba25ecf60e9879b21c36468

Reviewed-on: https://chromium-review.googlesource.com/3341633
WPT-Export-Revision: 04cab69c5c7cd6945503d3012930f3277a08375c

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 6 tests and 11 subtests

Status Summary

Firefox

OK : 2
PASS: 75
FAIL: 4[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 8[GitHub]

Chrome

OK : 2
PASS: 80
FAIL: 3

Safari

OK : 2
PASS: 77
FAIL: 6

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

New Tests That Don't Pass

  • /css/css-layout-api/style-map-multi.https.html [wpt.fyi]: FAIL [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: PASS, Safari: FAIL)
  • /css/css-layout-api/style-map.https.html [wpt.fyi]: FAIL [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: PASS, Safari: FAIL)
  • /css/css-paint-api/style-background-image.https.html [wpt.fyi]: FAIL [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: PASS, Safari: FAIL)
  • /css/css-paint-api/style-before-pseudo.https.html [wpt.fyi]: FAIL [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: PASS, Safari: FAIL)
  • /css/css-syntax/serialize-consecutive-tokens.html [wpt.fyi]
    • Comments are handled correctly when computing a/* comment */var(--t1) using t1:b.: FAIL (Chrome: PASS, Safari: PASS)
    • Comments are handled correctly when computing var(--t1)b using t1:a/* comment */.: FAIL (Chrome: PASS, Safari: PASS)
  • /css/css-variables/variable-cssText.html [wpt.fyi]
    • target4: FAIL (Chrome: FAIL, Safari: PASS)
    • target5: FAIL (Chrome: FAIL, Safari: PASS)

Tests Disabled in Gecko Infrastructure

  • /css/css-layout-api/style-map-multi.https.html [wpt.fyi]: FAIL [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: PASS, Safari: FAIL)
  • /css/css-layout-api/style-map.https.html [wpt.fyi]: FAIL [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: PASS, Safari: FAIL)
  • /css/css-paint-api/style-background-image.https.html [wpt.fyi]: FAIL [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: PASS, Safari: FAIL)
  • /css/css-paint-api/style-before-pseudo.https.html [wpt.fyi]: FAIL [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: PASS, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/14fa952a1399 [wpt PR 38905] - Trim whitespace around CSS custom declarations., a=testonly https://hg.mozilla.org/integration/autoland/rev/cd224d745bd0 [wpt PR 38905] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/14fa952a1399
https://hg.mozilla.org/mozilla-central/rev/cd224d745bd0

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox113: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
You need to log in before you can comment on or make changes to this bug.