1821363 - Inconsistent usage of xsimd batch type

Status: RESOLVED FIXED

(Core :: Web Audio, defect)

Description

[[:sergesanspaille]]

As spotted by https://launchpad.net/~ubuntu-mozilla-security/+archive/ubuntu/ppa/+build/25650811 some batch types are not parametrized by the correct architecture, which can lead to failed compilation.

Comment 1

[[:sergesanspaille]]

Attachment: Bug 1821363 - Use fully specified xsimd::batch type r=padenot

That way we cannot have one type using the default architecture that
interacts with the parametric type required by the user.

Comment 2

[[:sergesanspaille]]

Attachment: Bug 1821363 - Backport xsimd neon detection patch r=padenot

Depends on D172126

Comment 3

[Rico Tzschichholz]

Thank you for looking into this, but it still fails with the patches applied. See https://launchpad.net/~ubuntu-mozilla-daily/+archive/ubuntu/ppa/+build/25653863

Comment 4

[Jan Palus]

Fails on x86 32-bit as well with:

error: implicit instantiation of undefined template 'xsimd::batch<float, xsimd::sse2>'

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2759a85d2f94
Use fully specified xsimd::batch type r=padenot

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2759a85d2f94

Comment 7

[Mike Hommey [:glandium]]

Can you get this uplifted to beta?

Comment 8

[[:sergesanspaille]]

Comment on attachment 9322126 [details]
Bug 1821363 - Use fully specified xsimd::batch type r=padenot

Beta/Release Uplift Approval Request

• User impact if declined: Failure to compile on some native arm target.
• Is this code covered by automated tests?: Unknown
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1822901
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): not too risky as it has been verified by an Ubuntu maintainer.
  risky because it's my first time proposing an uplift to beta.
• String changes made/needed:
• Is Android affected?: Unknown

Comment 9

[Dianna Smith [:diannaS]]

Comment on attachment 9322126 [details]
Bug 1821363 - Use fully specified xsimd::batch type r=padenot

Approved for 112.0b6

Comment 10

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/cbc55e58a4b1