1821386 - Set the Milestone field when resolving bugs after PR merges

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: API, enhancement)

Description

[Ryan VanderMeulen [:RyanVM]]

One thing we overlooked in the specification for the Bugzilla/Github push hook was setting the Milestone flag when closing the bug (as is the case for commits when merged to mozilla-central).

We should set the same milestone version as the status flag we're setting to fixed (i.e. if status-firefox112:fixed, milestone should be 112 Branch). And to re-iterate, this is only applicable for commits landing on main when we're closing the bug as well (i.e. no action is needed for uplifts to other branches).

Comment 1

[Marco Castelluccio [:marco]]

Will this only be done when a bug is closed?
In pdf.js, we often merge PRs to the GitHub repo but then we sync the code in m-c only after a while, so there are cases where a PR is merged in a given release timeframe but then the code is synced only in the next release.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Is the pdf.js repo utilizing the new push hook that went live yesterday? Note that it already sets the status flag for the release to fixed, just not the Milestone.

Comment 3

[Marco Castelluccio [:marco]]

No, we are only using the pull_request hook at the moment.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Note that some products in Bugzilla don't have the milestones available. We should just ignore it in those cases.

Comment 5

[BMO Automation]

Attachment: [mozilla-bteam/bmo] Bug 1821386 - Set the Milestone field when resolving bugs after PR merges (#2034)

Comment 6

[David Lawrence [:dkl]]

Merged
https://github.com/mozilla-bteam/bmo/commit/285dd318518a09c3f17a0b85a32f7c85e82b5b2b