1821466 - [1.1] Add new Nimbus Messaging surface for Fullscreen Research Surfce

Status: VERIFIED FIXED

(Fenix :: General, enhancement)

Description

[Roger Yang [:royang]]

To support Fullscreen Research Surface, add a new MessageSurfaceId in Nimbus Messaging to support FULLSCREEN surface type.

This surface type will be used to open a fullscreen custom tab to the specified URL.

Comment 1

[[:skhan]]

Question : Current structure for survey includes only one button text that can be handled by nimbus. Does the second button text need to be hard coded into the UI? If not, which means second button text can be dynamic too, then we will need an updated message structure from Nimbus team.
Current Structure,

viewpoint-invitation-message:
text: "Please help Firefox by taking a short survey"
action: "https://qsurvey.mozilla.com/s3/302e5c853d63?app=android&userid=controlbranch"
trigger: [ "USER_EN_SPEAKER" ]
style: "URGENT"
type: "fullscreen"
button-label: "Take Survey"

Comment 2

[Joe M [:jmahon]]

Ah, very good question - I hope we can get away with just hard-coding that second button to "No Thanks" (at least for now), but we should check with the Product team. I'm going to forward this question to #mobile-messaging and loop you in there, Sarah. I'm going to leave my 'needinfo' on this ticket until I have a resolution with them, though.

Comment 3

[BMO Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1821466 - Add nimbus message for fullscreen reserach surface (#1245)

Comment 4

[BMO Github Automation]

Authored by https://github.com/sarah541
https://github.com/mozilla-mobile/firefox-android/commit/e2c014185f6470b45099abdf3c32bcd5b234ed8f
[main] Bug 1821466 - Add nimbus message for fullscreen research surface

Comment 5

[Chris Peterson [:cpeterson]]

We shouldn't uplift this fix to Beta 112 because it adds new strings that need to be localized.

Comment 6

[Joe M [:jmahon]]

Confirming decision: hard-coding the negative button to "No Thanks" (as per the Figma) is OK for this!

Comment 7

[Mira Lobontiu (Android QA)]

Attachment: Screenshot_3.jpg

Using a stage experiment and a local stage build, with the message, we have encountered the following:

• selecting to display the message on the homescreen, works as expected - tapping on the button redirects the user to the desired link,
• selecting to display the message in fullscreen does NOT work.

The setup of the experiment can be seen here.

Devices used: Samsung Galaxy A32 (Android 12), and Google Pixel 6 (Android 13).

Comment 8

[Roger Yang [:royang]]

Yes, currently all strings are hard-coded and will need to be localized.
:miralobontiu, the implementation for fullscreen has not been complete yet. The experiment setup will also be different than how we are triggering the homescreen message.

Comment 9

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1821466 - Update surface type to 'survey' (#1447)

Comment 10

[BMO Github Automation]

Authored by https://github.com/sarah541
https://github.com/mozilla-mobile/firefox-android/commit/c1a9e9823da30ca0fe5895b82bc32b34aa7bf577
[main] Bug 1821466 - Update surface type to 'survey'

Comment 11

[Mira Lobontiu (Android QA)]

We've updated the setup of the experiment with the "survey" modification. The setup of the experiment can be seen here.
On a stage experiment and a local stage build:

• selecting to display the message on the homescreen, works as expected - tapping on the button redirects the user to the desired link,
• selecting to display the message as a survey does NOT work.

I'll remove the qe-verify+ flag.

Comment 12

[Mira Lobontiu (Android QA)]

Verified as fixed on a local Release build from 5/4 with a Samsung Galaxy Note 8 (Android 9) device.