1821521 - [GITHUB] Only perform actions to a bug if branch is main, master, or a release branch. Ignore feature, bugfix branches, etc.

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: API, defect)

Description

[Jonathan Almeida [:jonalmeida]]

In bug 1821511, a change was made from a branch in the upstream project mobile-mobile/firefox-android.

Actual results:
On creating the pull request, the linked bug was immediately closed.

Expected results:
The bug is closed only once merged.

Comment 1

[David Lawrence [:dkl]]

(In reply to Jonathan Almeida [:jonalmeida] from comment #0)

In bug 1821511, a change was made from a branch in the upstream project mobile-mobile/firefox-android.

Actual results:
On creating the pull request, the linked bug was immediately closed.

Expected results:
The bug is closed only once merged.

Ok this might be serious so I may turn off support until this is fixed.

So to be clear, we should only be closing bugs if the commit is on either master or a release branch such as releases_v110?

Also, curious, was the pull request from a branch directly on the repository or from separate fork?

Thanks

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Only commits to main should close the bug. Commits to releases_vXXX should set the appropriate status flags and that's it.

Comment 3

[Jonathan Almeida [:jonalmeida]]

So to be clear, we should only be closing bugs if the commit is on either master or a release branch such as releases_v110?

What Ryan said, main.

Also, curious, was the pull request from a branch directly on the repository or from separate fork?

Yes, in the linked github issue, it was created from a branch directly on the upstream repository, not the fork.

Comment 4

[David Lawrence [:dkl]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #2)

Only commits to main should close the bug. Commits to releases_vXXX should set the appropriate status flags and that's it.

Ok understood about only closing bugs for commits to main. I was under the impressing

Comment 5

[BMO Automation]

Attachment: [mozilla-bteam/bmo] Bug 1821521 - [GITHUB} Only perform actions to a bug if branch is main, master, or a release branch. Ignore feature, bugfix branches, etc. (#2029)

Comment 6

[David Lawrence [:dkl]]

Merged
https://github.com/mozilla-bteam/bmo/commit/b6e18bbfb4a3fb2dc6648a3042d42cb61c51e828