Closed
Bug 1821620
Opened 2 years ago
Closed 2 years ago
Convert toolkit/components/forgetaboutsite to ES modules
Categories
(Toolkit :: Data Sanitization, task)
Toolkit
Data Sanitization
Tracking
()
RESOLVED
FIXED
113 Branch
Tracking | Status | |
---|---|---|
firefox113 | --- | fixed |
People
(Reporter: standard8, Assigned: tiwari.abhishektiwari23, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [esmification-timeline][lang=js])
Attachments
(1 file)
I'm happy to mentor work towards this bug. Please don't ask to be assigned to it, though you can say you're working on it. You'll be automatically assigned when you upload the first patches.
Here's what to do:
- Make sure you have a local build of Firefox up and running. Use these instructions if you haven't already.
- If you need help setting up, ask in #introduction on Matrix
- Using the ESMification walkthrough as a guide:
- Run
./mach esmify --convert path/to/files
- Examine the output for any errors from ESLint and fix them.
- Next convert the imports -
./mach esmify --import . --prefix path/to/files
- Again, check for any errors and fix them.
- Run a build to check it passes.
- Also run
./mach eslint --fix path/to/files
and check there are no raised failures - Please also update the documentation, specifically this line to change .jsm to .sys.mjs
- Commit the changes with a commit messages such as "Bug nnnnnn - Convert path/to/files to ES modules. r?Standard8"
- Run
- Use
moz-phab submit
to submit the patches for review.
Assignee | ||
Comment 1•2 years ago
|
||
Updated•2 years ago
|
Assignee: nobody → tiwari.abhishektiwari23
Status: NEW → ASSIGNED
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7d0fcc4ba0b1
Convert toolkit/components/forgetaboutsite to ES modules r=Standard8
Comment 3•2 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox113:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•