1821703 - Fix sponsored shortcuts jank

Status: RESOLVED FIXED

(Fenix :: Homepage, enhancement, P2)

Description

[Joe M [:jmahon]]

If the keyboard is up and you switch to or from Private Browsing mode, ... the sponsored shortcuts reload.

(JM note: split out from https://bugzilla.mozilla.org/show_bug.cgi?id=1818624, it was originally a single statement reported by Verdi here)

Comment 1

[Chris Peterson [:cpeterson]]

Tasks should have Severity N/A.

Comment 2

[[:harrisono]]

I found a new way to replicate the "reloading" of the sponsored tiles:

Steps to reproduce:

1. Close all tabs. This will leave you in the normal browsing home page.
2. Open tabs tray and click New Tab FAB.

Expected:

• User is still on homepage but cursor moves to awesomebar and keyboard goes up. No top sites or sponsored site tiles reload

Actual:

• User is still on homepage but cursor moves to Awesomebar and keyboard goes up. Top sites and Pinned sites are not reloaded but Sponsored Site tiles are reloaded (shows as a flash of the icon for the Sponsored Site).

Comment 3

[[:harrisono]]

Investigation results:

I located a block that I think is responsible for the re-loading "flash" of the Sponsored Sites when the homepage is reloaded.

https://searchfox.org/mozilla-mobile/source/firefox-android/fenix/app/src/main/java/org/mozilla/fenix/home/topsites/TopSiteItemViewHolder.kt

In the bind function, lines 149-159. The if (topSite is TopSite.Provided) loop is causing the flash. I commented out those lines and the icons changed for the Sponsored Sites and those tiles no longer flash-reloaded when the homepage was reloaded.

Further investigation is needed.

Comment 4

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1821703 - Added cache to TopSites to store fetched favicons (#4079)

Comment 5

[BMO Github Automation]

Authored by https://github.com/t-p-white
https://github.com/mozilla-mobile/firefox-android/commit/ae037430b66835e48b2a5da2838546cd131dc4c4
[main] Bug 1821703 - Fix Compose Top Site Sponsored Sites 'flashing' appearance

Comment 6

[Adina Petridean QA [:apetridean]]

Verified as fixed on Nightly 121.0a1 from 11/15 with Sony Xperia (Android 6.0.1) and Motorola Moto G9 plus (Android 11).

Comment 7

[Adina Petridean QA [:apetridean]]

Attachment: sponsored.mp4

Comment 8

[Verdi [:verdi] Best to slack me]

I can still reproduce this in Firefox 123 on my Samsung S9

Comment 9

[twhite]

verdi is that with 'enable Compose Top Sites' secret setting enabled?

Comment 10

[Verdi [:verdi] Best to slack me]

Attachment: Screen_Recording_20240308-125201_Firefox Nightly.mp4

(In reply to twhite from comment #9)

verdi is that with 'enable Compose Top Sites' secret setting enabled?

Ah - I missed that part. That setting isn't available in release so I just turned in on in Nightly 125 and I do see one of the two sponsored sites reloads when I switch.