1821724 - Pocket stories column alignment fix

Status: VERIFIED FIXED

(Firefox for Android :: Homepage, enhancement, P3)

Description

[Joe M [:jmahon]]

On some devices the third column of stories doesn’t align with the heading - See Screenshot

• JM notes: "Discussed in meeting - might actually be working as intended? phone size could be a cause"
• GL notes: "If we want to look into fixing this, estimate is M"

Originally taken from here

Note: I'm not sure if we settled exactly what to change about this. Whoever picks this up should follow up with UX before beginning. I think the expectation was that the 3rd column should line up on the left, leaving a bit of a gap on the right side of the screen.

Comment 1

[Joe M [:jmahon]]

Attachment: pocket stories column alignment.png

Comment 2

[Chris Peterson [:cpeterson]]

Tasks should have Severity N/A.

Comment 3

[twhite]

Attachment: Mock up of potential update

Provided a quick mock-up for discussion with UX

Comment 4

[Verdi [:verdi] Best to slack me]

Attachment: Correct alignment

For some reason it's currently working correctly on my Samsung Galaxy9. The last row should work like the other ones and fill the column leaving only the margins on the left and right.

Comment 5

[Verdi [:verdi] Best to slack me]

Attachment: Better example

Here's a better example. You can see how the card lines up with the title on the left and is the same width as the Collections card above.

Comment 6

[twhite]

Thanks [:verdi]

Comment 7

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1821724 - Pocket column alignment fixed for PORTRAIT orientation (#2312)

Comment 8

[BMO Github Automation]

Authored by https://github.com/t-p-white
https://github.com/mozilla-mobile/firefox-android/commit/1cd69fec56725410af855eda923ab1afe99ae0b2
[main] Bug 1821724 - Pocket column alignment fixed for all orientations

Comment 9

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Revert "Bug 1821724 - For Portrait mode, align the Pocket column with the column title " (#2371)

Comment 10

[BMO Github Automation]

Authored by https://github.com/t-p-white
https://github.com/mozilla-mobile/firefox-android/commit/d7738e7178636d1890f0edd5ad919940e1118780
[main] Revert "Bug 1821724 - Pocket column alignment fixed for all orientations" (#2371)

Comment 11

[Ryan VanderMeulen [:RyanVM]]

This was backed out for causing bug 1837322.

Comment 12

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1821724 - Align the Pocket column with the column title in portrait (#2391)

Comment 13

[BMO Github Automation]

Authored by https://github.com/t-p-white
https://github.com/mozilla-mobile/firefox-android/commit/6260b705942c0fd0529150558acd2d5c8de75a24
[main] Bug 1821724 - Pocket column alignment fixed for all orientations

Comment 14

[Lorand Janos]

Verified as fixed on the latest Nightly 116.0a1 (2023-06-13) build.
The third card is now aligned with the title on the left.
Attached a video with the latest Beta 114.0b4 as an example of how it was before, then on the latest Nightly.
Marking as fixed for 116.

Comment 15

[Lorand Janos]

Attachment: az_recorder_20230613_081907.mp4