1821727 - Refactor the NativeLayerCA clip geometry calculations

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Brad Werth [:bradwerth]]

Clip geometry is calculated the same way in two locations: ApplyChanges and DumpLayer. Refactor this code to its own function and call the new function from both locations.

Comment 1

[Brad Werth [:bradwerth]]

Attachment: Bug 1821727: Refactor NativeLayerCA clip rect geometry calcuations.

This creates a new method that is used in ApplyChanges and DumpLayer to
calculate the clip rect geometry. Along the way, it eliminates some
redundant outputs:

1. effectiveClip is just a holder of both the position and bounds of the
   clip, which are applied seperately by the caller, so the new function
   returns them seperately.
2. clipToLayerOffset is just the unscaled negated value of the clip
   position, and the only place it is used can tolerate doing the math at the
   point of use.

It also reorganizes the logic in DumpLayer a bit to more cleanly separate
the parts that output the wrapping div from the parts that output the img.

Unfortunately, it also re-lints the files it touches, which were somehow
out of compliance with current linting rules, so the changes look much
more extensive than they are.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae7a9ef40963
Refactor NativeLayerCA clip rect geometry calcuations. r=mstange

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/ae7a9ef40963