1821900 - Convert toolkit/components/terminator/ to ES modules

Status: RESOLVED FIXED

(Toolkit :: Async Tooling, task, P3)

Description

[Mark Banner (:standard8)]

I'm happy to mentor work towards this bug. Please don't ask to be assigned to it, though you can say you're working on it - please respect other contributors comments as well. You'll be automatically assigned when you upload the first patches.

Here's what to do:

• Make sure you have a local build of Firefox up and running. Use these instructions if you haven't already.
  • If you need help setting up, ask in #introduction on Matrix
• Using the ESMification walkthrough as a guide:
  1. Run ./mach esmify --convert path/to/files
  2. Examine the output for any errors from ESLint and fix them.
  3. Next convert the imports - ./mach esmify --import . --prefix path/to/files
  4. Again, check for any errors and fix them.
  5. Run a build to check it passes.
  6. Also run ./mach eslint --fix path/to/files and check there are no raised failures
  7. Commit the changes with a commit messages such as "Bug nnnnnn - Convert path/to/files to ES modules. r?Standard8"
• Use moz-phab submit to submit the patches for review.

Comment 1

[Abhishek[: unavailable till 11 May]]

Sir, Can I work on this bug, this is an easy one I know, and I have solved such bugs, but as you suggested I worked on harder bugs also I have made some patches and also asked for guidance in the comments with my research on eash bug but didn't get any response yet. And I am only contributing to firefox because I don't want to distract myself from this community,

Comment 2

[Abhishek[: unavailable till 11 May]]

And it had been 7 hr, and no one had commented yet!

Comment 3

[Pushpanjali]

I would like to work on this bug, I am an outreachy intern.

Comment 4

[Mark Banner (:standard8)]

Abhishek, lets focus on sorting out your existing issues, and then once we've got those landed we can find some more to work on. This is a good one for fresh beginners.

Puspanjali, welcome. As per comment 0, please start working on it, it'll be auto-assigned when the first patch is uploaded.

Comment 5

[Abhishek[: unavailable till 11 May]]

Ok, sir, I am trying some second and third-good first issues. And some not good first issues also. Thanks

Comment 6

[Pushpanjali]

(In reply to Mark Banner (:standard8) from comment #4)

Abhishek, lets focus on sorting out your existing issues, and then once we've got those landed we can find some more to work on. This is a good one for fresh beginners.

Puspanjali, welcome. As per comment 0, please start working on it, it'll be auto-assigned when the first patch is uploaded.

Yes sir

Comment 7

[Pushpanjali]

Attachment: WIP: Bug 1821900 Convert toolkit/components/terminator/ to ES modules

Comment 8

[Mark Banner (:standard8)]

@Pushpanjali please can you update the commit message to be Bug 1821900 - Convert toolkit/components/terminator/ to ES modules. r?Standard8 (use hg commit --amend) and then re-submit using moz-phab submit.

As you didn't specify the reviewer (the r?Standard8 part), the patch is flagged as "Work in Progress" (WIP) which means that it doesn't get into anyone's review queue, and any comments on it are not posted anywhere. We need it in the non-WIP state to progress it.

Comment 9

[Pushpanjali]

Yes sir, working on it.

Comment 10

[Pushpanjali]

Attachment: Bug 1821900 - Convert toolkit/components/terminator/ to ES modules r=standard8

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb7ad7a37229
Convert toolkit/components/terminator/ to ES modules r=Standard8

Comment 12

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/fb7ad7a37229