1821927 - Convert toolkit/components/tooltiptext to ES modules

Status: RESOLVED FIXED

(Toolkit :: General, task, P3)

Description

[Mark Banner (:standard8)]

I'm happy to mentor work towards this bug. Please don't ask to be assigned to it, though you can say you're working on it - please respect other contributors comments as well. You'll be automatically assigned when you upload the first patches.

Here's what to do:

• Make sure you have a local build of Firefox up and running. Use these instructions if you haven't already.
  • If you need help setting up, ask in #introduction on Matrix
• Using the ESMification walkthrough as a guide:
  1. Run ./mach esmify --convert path/to/files
  2. Examine the output for any errors from ESLint and fix them.
  3. Next convert the imports - ./mach esmify --import . --prefix path/to/files
  4. Again, check for any errors and fix them.
  5. Run a build to check it passes.
  6. Also run ./mach eslint --fix path/to/files and check there are no raised failures
  7. Commit the changes with a commit messages such as "Bug nnnnnn - Convert path/to/files to ES modules. r?Standard8"
• Use moz-phab submit to submit the patches for review.

Comment 1

[Noah Osuolale]

Hi, I am currently working on it

Comment 2

[Noah Osuolale]

Attachment: Bug 1821927 - Convert toolkit/components/tooltiptext to ES modules. r?Standard8

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e58fc5e4884f
Convert toolkit/components/tooltiptext to ES modules. r=Standard8

Comment 4

[Noemi Erli[:noemi_erli]]

Backed out 2 changesets (Bug 1821927, Bug 1822012) for causing failures in browser_startup.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=Tc-cy5JPTii63RvwdDCpVg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=5c3e9356fdd32b2b250de9fd3bca006cb0e1c36a

Log: https://treeherder.mozilla.org/logviewer?job_id=408836224&repo=autoland&lineNumber=5769

Backout: https://hg.mozilla.org/integration/autoland/rev/1295e912f414beb2b3919719bc8088a73bd26e32

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/690d769edf71
Convert toolkit/components/tooltiptext to ES modules. r=Standard8

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/690d769edf71