Closed
Bug 1821928
Opened 1 year ago
Closed 1 year ago
Convert toolkit/components/translation to ES modules
Categories
(Firefox :: Translations, task)
Firefox
Translations
Tracking
()
RESOLVED
FIXED
113 Branch
Tracking | Status | |
---|---|---|
firefox113 | --- | fixed |
People
(Reporter: standard8, Assigned: osuolale49, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [esmification-timeline][lang=js])
Attachments
(1 file)
I'm happy to mentor work towards this bug. Please don't ask to be assigned to it, though you can say you're working on it - please respect other contributors comments as well. You'll be automatically assigned when you upload the first patches.
Here's what to do:
- Make sure you have a local build of Firefox up and running. Use these instructions if you haven't already.
- If you need help setting up, ask in #introduction on Matrix
- Using the ESMification walkthrough as a guide:
- Run
./mach esmify --convert path/to/files
- Examine the output for any errors from ESLint and fix them.
- Next convert the imports -
./mach esmify --import . --prefix path/to/files
- Again, check for any errors and fix them.
- Run a build to check it passes.
- Also run
./mach eslint --fix path/to/files
and check there are no raised failures - Commit the changes with a commit messages such as "Bug nnnnnn - Convert path/to/files to ES modules. r?Standard8"
- Run
- Use
moz-phab submit
to submit the patches for review.
Assignee | ||
Comment 1•1 year ago
|
||
Hi, I am currently working on it
Comment 2•1 year ago
|
||
I am currently working it.
Comment 3•1 year ago
|
||
I get this error when I run
./mach esmify --import . --prefix path/to/files
ERR ../../devtools/client/shared/source-map-loader/test/browser/fixtures/bundle.js Transformation error (Unexpected token (65:17))
SyntaxError: Unexpected token (65:17)
Can you help please
Assignee | ||
Comment 4•1 year ago
|
||
Updated•1 year ago
|
Assignee: nobody → osuolale49
Status: NEW → ASSIGNED
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8a0a4d989dc9 Convert toolkit/components/translation to ES modules. r=Standard8,extension-reviewers,robwu
Comment 6•1 year ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox113:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•