1821991 - [PL][bonprix] Card Type dropdown is not autofilled or highlighted

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, defect, P2)

Description

[Ina Popescu, Desktop QA]

Attachment: bonprix_card type.mp4

Found in

• Firefox 111

Affected versions

• Firefox 111

Tested platforms

• Affected platforms: Windows 10

Preconditions

• set pref extensions.formautofill.creditCards.supportedCountries to IT,ES,PL,AT,BE in about:config
• set pref browser.search.region to PL in about:config
• use PL VPN
• have several credit cards saved in about:preferences#privacy

Steps to reproduce

1. Go to https://www.bonprix.pl/
2. Add an item to cart and proceed to checkout
3. Reach the payment page
4. Click in the Card Number field

Expected result

• The Card Type is properly autofilled and highlighted when using autofill preview.

Actual result

• The Card Type is not autofilled or highlighted when using autofill preview.

Regression range

• Not a regression because this feature is disabled by default.

Additional notes

• The issue is not reproduceable in Google Chrome.
• Fathom Fox downloaded page: https://drive.google.com/file/d/15gZUtyL3TdzbRWrz2cC61Fk69PiY91uf/view?usp=sharing

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:epopescu, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Dimi Lee [:dimi]]

We didn't run this credit card type detection heuristic:
https://searchfox.org/mozilla-central/rev/815764d6f304cd69b60075e83b06320464a66223/toolkit/components/formautofill/shared/FormAutofillHeuristics.sys.mjs#347-360

Comment 3

[Dimi Lee [:dimi]]

Attachment: Bug 1821991 - Fix an issue that `cc-type` heuristic is not executed r=#credential-management-reviewers

"In _parseXXX methods, heuristics are used when identifying a field to apply
additional information to correct or update its type. For example, when
identifying cc-exp using a regular expression-based heuristic, we update it
to cc-exp-month along with other relevant information.

However, the heuristic used for matching select options in cc-type is not meant
for updating, but rather for discovering the field type of a given element.
Placing this heuristic in _parseCreditCardField would prevent the discovery of
an element being a cc-type using this approach.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f4d5f746ef26
Fix an issue that `cc-type` heuristic is not executed r=credential-management-reviewers,sgalich

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f4d5f746ef26

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:dimi, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox114 to wontfix.

For more information, please visit BugBot documentation.

Comment 8

[Ina Popescu, Desktop QA]

Verified as fixed on the latest Nightly 116.0a1 (2023-06-05) version on Windows 10 x64 where the issue no longer persists.