Closed Bug 1822010 Opened 1 year ago Closed 1 year ago

Convert toolkit/components/url-classifier to ES modules

Categories

(Toolkit :: Safe Browsing, task)

task

Tracking

()

RESOLVED FIXED
115 Branch
Tracking Status
firefox115 --- fixed

People

(Reporter: standard8, Assigned: nemanaina9, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [esmification-timeline][lang=js])

Attachments

(1 file)

I'm happy to mentor work towards this bug. Please don't ask to be assigned to it, though you can say you're working on it - please respect other contributors comments as well. You'll be automatically assigned when you upload the first patches.

Here's what to do:

  • Make sure you have a local build of Firefox up and running. Use these instructions if you haven't already.
  • Using the ESMification walkthrough as a guide:
    1. Run ./mach esmify --convert path/to/files
    2. Examine the output for any errors from ESLint and fix them.
    3. Next convert the imports - ./mach esmify --import . --prefix path/to/files
    4. Again, check for any errors and fix them.
    5. Run a build to check it passes.
    6. Also run ./mach eslint --fix path/to/files and check there are no raised failures
    7. Commit the changes with a commit messages such as "Bug nnnnnn - Convert path/to/files to ES modules. r?Standard8"
  • Use moz-phab submit to submit the patches for review.

Hi, I'm Ayesha Solanki, an Outreachy applicant. I would like to contribute on this issue. Can you assign it to me?

(In reply to Ayesha Solanki from comment #1)

Hi, I'm Ayesha Solanki, an Outreachy applicant. I would like to contribute on this issue. Can you assign it to me?

Hi, please see the start of comment 0 - you can start working on it without it being assigned, if no-one else has already commented on it.

Hi, I am currently looking at this bug. Am I to covert all the .jsm files in this directory (toolkit/components/url-classifier) to sys.mjs?

(In reply to Noah Osuolale from comment #3)

Hi, I am currently looking at this bug. Am I to covert all the .jsm files in this directory (toolkit/components/url-classifier) to sys.mjs?

Hi, please read the previous comments - Ayesha have already said they are working on this. There should be other bugs around that you can pick up instead.

This is noted. Thanks

As there is not update in this bug yet, Can i work on it?

(In reply to Pushpanjali from comment #6)

As there is not update in this bug yet, Can i work on it?

I think you can go ahead, since Ayesha hasn't appeared again. If Ayesha still wants something I can find one for them.

(In reply to Mark Banner (:standard8) from comment #7)

(In reply to Pushpanjali from comment #6)

As there is not update in this bug yet, Can i work on it?

I think you can go ahead, since Ayesha hasn't appeared again. If Ayesha still wants something I can find one for them.

I can quickly create a patch for this. Should I go ahead?

(In reply to Mark Banner (:standard8) from comment #7)

(In reply to Pushpanjali from comment #6)

As there is not update in this bug yet, Can i work on it?

I think you can go ahead, since Ayesha hasn't appeared again. If Ayesha still wants something I can find one for them.

yes sir

this is open
can i?

Assignee: nobody → nemanaina9
Status: NEW → ASSIGNED
Attachment #9324602 - Attachment description: Bug 1822010 - Convert toolkit/components/url-classifier to ES modules r=Standard8 → Bug 1822010 - Convert toolkit/components/url-classifier to ES modules. r?timhuang!
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/473def04b584
Convert toolkit/components/url-classifier to ES modules. r=perftest-reviewers,webcompat-reviewers,geckoview-reviewers,devtools-reviewers,twisniewski,valentin,m_kato,anti-tracking-reviewers,timhuang,sparky
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: