1822027 - The link of the third Sponsored tile is displayed first in the Address Bar results drop down

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Description

[Carmen Fat [:cfat] - Ecosystem QA, PTO until August 22nd - NI to: [e-mail]]

Attachment: 3rd tile link.jpg

[Affected versions]:

• Firefox Nightly 112.0a1 - Build ID: 20230309093044

[Affected Platforms]:

• Windows 10 x64
• macOS 12.4
• Linux Ubuntu 20.04 x64

[Prerequisites]:

• Have a VPN client connected to a US server (for users located outside US).
• Have the nimbus.debug pref set to true.

[Steps to reproduce]:

1. Open the browser from the prerequisites.
2. Copy and paste the following link in a new tab:
   about:studies?optin_slug=showing-3rd-sponsored-tile-on-the-newtab-page&optin_branch=treatment&optin_collection=nimbus-preview
3. Open a new tab.
4. Click inside the Address Bar.
5. Observe the Top Sites from the drop down.

[Expected result]:

• Only the default Top Sites are displayed.

[Actual result]:

• The link of the third Sponsored tile is displayed first in the results drop down.

[Notes]:

• Attached is a screenshot of the issue.

Comment 1

[Nan Jiang [:nanj]]

Attachment: Bug 1822027 - Do not show SPOC topsites in the URLbar r=thecount

Comment 2

[Nan Jiang [:nanj]]

[Tracking Requested - why for this release]: this is a bugfix for a feature agains which we're going to run an experiment in release 112.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/06e8176d1df1
Do not show SPOC topsites in the URLbar r=thecount

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/06e8176d1df1

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:nanj, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox112 to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Nan Jiang [:nanj]]

Comment on attachment 9323957 [details]
Bug 1822027 - Do not show SPOC topsites in the URLbar r=thecount

Beta/Release Uplift Approval Request

• User impact if declined: The experiment user group will see an unexpected sponsored topsite in the URL bar.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce:
  • Force enroll into the treatment branch of the 3rd sponsored tile experiment
  • Click on the URL bar, the sponsored topsite (Mozilla VPN) should not be displayed in the dropdown list
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch would only apply to some experiment users, we can turn off the experiment through Nimbus if needed.
• String changes made/needed: None
• Is Android affected?: No

Comment 7

[Nan Jiang [:nanj]]

Hi Carmen, could you verify the fix in Nightly when you get a chance? Thanks!

Comment 8

[Carmen Fat [:cfat] - Ecosystem QA, PTO until August 22nd - NI to: [e-mail]]

I have verified this issue on the latest Firefox Nightly 113.0a1 (Build ID: 20230321213816), on Windows 10 x64, macOS 12.6.1, and Ubuntu 20.04 x64.

• The link of the Pocket Sponsored tile is no longer displayed in the Address Bar drop-down list.
• Verified this by focusing (click or Ctrl+L) the Address Bar from new tabs opened via "+" button and shortcut (Ctrl+T).
• Verified using the Main, New, and Private Windows, and also in Safe Mode.

Comment 9

[Dianna Smith [:diannaS]]

Comment on attachment 9323957 [details]
Bug 1822027 - Do not show SPOC topsites in the URLbar r=thecount

Approved for 112.0b6

Comment 10

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/58d27acdcaae

Comment 11

[Carmen Fat [:cfat] - Ecosystem QA, PTO until August 22nd - NI to: [e-mail]]

I have verified this issue on the latest Firefox Beta 112.0b6 (Build ID: 20230323181038), on Windows 10 x64, macOS 12.6.1, and Ubuntu 20.04 x64.

• The link of the Pocket Sponsored tile is no longer displayed in the Address Bar drop-down list.
• Verified this by focusing (click or Ctrl+L) the Address Bar from new tabs opened via "+" button and shortcut (Ctrl+T).
• Verified using the Main, New, and Private Windows, and also in Safe Mode.