Closed
Bug 1822037
Opened 2 years ago
Closed 2 years ago
Consider removing redundant isAppTab setter code
Categories
(WebExtensions :: General, task, P3)
Tracking
(firefox113 fixed)
RESOLVED
FIXED
113 Branch
| Tracking | Status | |
|---|---|---|
| firefox113 | --- | fixed |
People
(Reporter: Gijs, Assigned: Gijs)
References
Details
Attachments
(2 files)
As noted in https://phabricator.services.mozilla.com/D171412#5665053 and the preceding comment, given https://searchfox.org/mozilla-central/rev/af78418c4b5f2c8721d1a06486cf4cf0b33e1e8d/docshell/base/nsDocShell.cpp#12974 we're not quite sure whether the webextension code really needs to set isapptab to true at all.
Given the wide scope of bug 1718082 we're moving evaluating this to a follow-up bug.
|
||
Updated•2 years ago
|
Severity: -- → N/A
Type: defect → task
Priority: -- → P3
|
Assignee | |
Comment 1•2 years ago
|
||
|
||
Updated•2 years ago
|
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•2 years ago
|
||
Depends on D173089
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/58f8d1b47bd8
don't bother setting isAppTab for extension browsers, r=rpl
https://hg.mozilla.org/integration/autoland/rev/56b447ce6ceb
actually test that popup and options pages open links in tabs rather than their own browsers, r=rpl
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/58f8d1b47bd8
https://hg.mozilla.org/mozilla-central/rev/56b447ce6ceb
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox113:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•