Closed Bug 1822049 Opened 2 years ago Closed 1 month ago

[ES][jdsports.es] The autofill is not working at all for the CC Name field and the expiry date autofill is working only for it's field

Categories

(Toolkit :: Form Autofill, defect, P2)

Firefox 111
Desktop
Windows 10
defect

Tracking

()

VERIFIED FIXED
Tracking Status
firefox111 --- disabled
firefox112 --- disabled
firefox113 --- disabled

People

(Reporter: ailea, Unassigned)

References

(Depends on 1 open bug, Blocks 1 open bug, )

Details

(Whiteboard: [fxcm-cc-new-geo])

Attachments

(4 files)

Found in

  • 111.0-candidates

Affected versions

  • 111.0-candidates

Tested platforms

  • Affected platforms: Windows 10

Preconditions

  • browser.search.region = ES
  • extensions.formautofill.creditCards.supportedCountries = ES
  • have at least one already saved CC in about:preferences

Steps to reproduce

  1. Reach the payment form on https://www.jdsports.es
  2. Click on the CC Name field
  3. Click on the expiry date field and hover the mouse over any CC entry from the dropdown
  4. Select any CC entry from the dropdown
  5. Click on the expiry date field and choose to clear form
  6. Click on the CC number field and select any CC entry from the dropdown
  7. Click on the expiry date field
  8. Click on the CC number field and select clear form

Expected result

  1. The CC dropdown should be displayed and the autofill should work for any eligible CC field.
  2. Preview should be applied on eligible fields.
  3. Choosing a CC entry from any CC fields should autofill all the CC eligible fields.
  4. Clear form dropdown should be displayed for the already autofilled fields and should clear all the CC eligible fields.
  5. The autofill highlight should be displayed for all the CC fields.

Actual result

  1. The CC dropdown is not displayed and the autofill is not working for the CC Name field.
  2. The preview is applied only for the selected field.
  3. All the CC fields are autofilled only if choosing a CC entry from the CC Number field. The expiry date field will autofill only itself.
  4. Clear form dropdown is displayed and clears only the selected field.
  5. The autofill highlight is displayed only for the selected field.

Regression range

  • N/A

Additional notes

  • CC Name field has the autocomplete = off attribute.
  • Not reproducible on Chrome.
Attached file www.jdsports.es.html

For some reason, the page for this website is not downloaded correctly.

Priority: -- → P2
Whiteboard: [fxcm-cc-new-geo]

CC name input field is outside of where its label is rendered. We'd likely need to have a new rule that detects and makes this association.

As for autofill fields not being applied when one field is filled, I imagine this would need to be addressed in Bug 1815399 since the fields are also in their own iframe.

Depends on: 1815399

Investigated this one again and found that our fathom rules for cc-name produce a confidence score 0.67 and that the labelsMatchRegExp successfully match for the associated label when we add the keyword nombre.*tarjeta.

However, the cc-number and cc-exp fields are isolated in their own iframes, so we don't evaluate cc-name as a valid field. And because the confidence score is only 0.67, the high threshold check doesn't pass either.

Dimi, is it safe to say this issue will be resolved when Bug 1815399 is fulfilled? I think in the meantime we can just add the keyword.

Flags: needinfo?(dlee)

(In reply to Micah [:mtigley] (she/her) from comment #3)

Dimi, is it safe to say this issue will be resolved when Bug 1815399 is fulfilled? I think in the meantime we can just add the keyword.

Sounds good!

Flags: needinfo?(dlee)

I've retested this on the latest Nightly 132.0a1 on macOS 14.

  • Triggering autofill from “CC number” and “Date” fields isn't autofilling "CC name" field
  • Clearing autofill from “CC number” and “Date” fields isn’t clearing “Name” field
  • Triggering autofill/clearing from “Name” field is only autofilling/clearing “Name” field

When the extensions.formautofill.heuristics.autofillSameOriginWithTop setting is set to true, clearing autofill from any field is clearing all the targeted fields, but not if the triggered from "CC name" field.

The "CC Name" field is situated on the main page, and not inside an iframe, unlike the 'Card Number' and 'Expiry Date' fields which are located within same-origin iframes.
Video recording: https://imgur.com/a/0JfVooU

Fixed by bug 1916606. The CC Name field that is located in the main frame, is now autofilled and cleared accordingly.
As we agreed with the engineering team and based on this comment, I will mark this as fixed and verified.

Status: NEW → RESOLVED
Closed: 1 month ago
Depends on: 1916606
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: