1822062 - All content processes receive an IPC whenever the new tab page is updated

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Florian Quèze [:florian]]

See this profile of Firefox being idle for multiple hours: https://share.firefox.dev/425QUGf

Whenever the new tab page is updated, the privileged content process sends an PContent::Msg_StartVisitedQueries IPC to the parent, that then sends PContent::Msg_NotifyVisited messages to all content processes (including preallocated content processes and the webextension process).

Is this the expected behavior? Was bug 1714614 meant to avoid this?

Comment 1

[Emilio Cobos Álvarez [:emilio]]

What URI(s) are we sending in NotifyVisited? Whenever we visit a new URI we need to broadcast that to all processes.

Comment 2

[Florian Quèze [:florian]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #1)

What URI(s) are we sending in NotifyVisited?

Most of the time, none.

Comment 3

[Florian Quèze [:florian]]

Attachment: Bug 1822062 - avoid sending NotifyVisited IPCs with no URIs, r=emilio.

Comment 4

[Florian Quèze [:florian]]

(In reply to Florian Quèze [:florian] from comment #2)

(In reply to Emilio Cobos Álvarez (:emilio) from comment #1)

What URI(s) are we sending in NotifyVisited?

Most of the time, none.

Example profile (without the fix, but with extra debug markers) showing this: https://share.firefox.dev/3ZRjt8N

Profile with the fix and the same debug markers: https://share.firefox.dev/3ZSWrOU We no longer wake-up the preallocated content processes when updating the cached new tab page in the privileged content process.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7dce2a070dda
avoid sending NotifyVisited IPCs with no URIs, r=emilio.

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/7dce2a070dda