1822072 - Split up tabbrowser's addTab to reduce its complexity and improve readability

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, task)

Description

[:Gijs (he/him)]

Splitting this off from bug 1818777 because it'll be quick to bitrot and I'm still working through some of the issues in 1818777 itself to avoid having to deal with null URI objects all the time.

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1822072 - split up tabbrowser's addTab so it's easier to understand, r=dao

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f0bc703cf531
split up tabbrowser's addTab so it's easier to understand, r=dao

Comment 3

[Norisz Fay [:noriszfay]]

Backed out for causing bc failures on browser_ext_tabs_discard_reversed.js

Backout link

Push with failures

Failure log

Comment 4

[:Gijs (he/him)]

Seems like we depend on overwriting the URI string if we're not actually loading it, and my initial patch forgot to do this. Looks like I didn't notice this in my trypush because it included the next patch in this series which switches away from the string input to passing a real URI object.

Pushing to try with just this patch to make sure this is fixed before relanding, given that it's annoying to break so much hg annotate/blame info if this keeps getting backed out:

https://treeherder.mozilla.org/jobs?repo=try&revision=4ddd246d2cc90738bd10a66d54f278ccb9f61e88

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/54f18d7015d0
split up tabbrowser's addTab so it's easier to understand, r=dao

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/54f18d7015d0