1822075 - [ES][hsnstore.com] The autofill is not working at all for any of the CC fields

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, defect, P2)

Description

[Alin Ilea, Desktop Test Engineering]

Attachment: 2023-03-13_17h00_29.mp4

Found in

• 111.0-candidates

Affected versions

• 111.0-candidates

Tested platforms

• Affected platforms: Windows 10

Preconditions

• browser.search.region to ES
• extensions.formautofill.creditCards.supportedCountries to ES
• have an already CC saved in about:preferences

Steps to reproduce

1. Reach the payment form on https://www.hsnstore.com
2. Click on any CC field in order to trigger de CC dropdown

Expected result

• The autofill dropdown should be displayed for each eligible CC field and choosing a CC entry should autofill all the eligible CC fields.

Actual result

• The autofill dropdown is not displayed for any of the CC fields.

Regression range

• N/A

Additional notes

• Not reproducible in Chrome.
• CC Number field has the autocomplete = "off" attribute.
• Fathom Fox Sample

Comment 1

[Micah [:mtigley] (she/her)]

Let's focus on the CC name field. We can add a phrase that will match the placeholder attribute for that field here, but unfortunately our model's confidence score doesn't pass: https://searchfox.org/mozilla-central/rev/f078cd02746b29652c134b144f0629d47e378166/toolkit/components/formautofill/FormAutofillHandler.jsm#1111-1113.

Does this mean we will need to retrain our model with more samples where placeholder attribute matches?

Comment 2

[Micah [:mtigley] (she/her)]

Instead of re-training our model with this specific case, let's explore adding a new rule (or use an existing) that will aid in a higher confidence score.

Comment 3

[Micah [:mtigley] (she/her)]

This issue should now be fixed in the latest Nightly, Alin would you be able to verify this?

Comment 4

[Alin Ilea, Desktop Test Engineering]

Attachment: 2023-06-21_14h38_07.mp4

Hi Micah,
I just verified in the latest Nightly 116.0a1(2023-06-21) and unfortunately I am still able to reproduce the issue.

Comment 5

[Alin Ilea, Desktop Test Engineering]

Attachment: 2023-07-06_14h47_29.mp4

Verified again this issue and the autofill is working now for CC Name and expiry date fields. The CC dropdown is still not displayed and the autofill is not working for the CC Number field.

Comment 6

[Micah [:mtigley] (she/her)]

The CC Number field in the video is within its own iframe after inspecting the HTML. This work would be addressed in Bug 1815399. Otherwise, I believe we can mark this as fixed since it's working for CC name and expiry date fields?

Comment 7

[Dimi Lee [:dimi]]

(In reply to Micah [:mtigley] (she/her) from comment #6)

The CC Number field in the video is within its own iframe after inspecting the HTML. This work would be addressed in Bug 1815399. Otherwise, I believe we can mark this as fixed since it's working for CC name and expiry date fields?

Yes,

Hi Alin, could you help file another bug for the cc-number issue, thank you!

Comment 8

[Alin Ilea, Desktop Test Engineering]

Sure thing, here the new bug for the issue mentioned above.