1822116 - Image is rotated differently in Chrome and Firefox

Status: VERIFIED FIXED

(Core :: Layout: Images, Video, and HTML Frames, defect)

Description

[Thomas Wisniewski [:twisniewski][PTO until the 26th]]

Attachment: testcase.html

In the attached test-case, the JPEG image has a particular combination of crossorigin=anonymous, transform:rotate(90deg), and image-orientation:none. Something about this combination seems to cause Chrome to rotate it -90 degrees again despite the transform, while Firefox does not do so.

Dropping the crossorigin attribute causes Chrome to not rotate the image -90 degrees again, but I'm not well versed in whether or how these attributes are supposed to interplay, so I thought a second opinion would be good here.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:emilio, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Dan Robertson (:dlrobertson)]

The fix for this should be easy. To match the behavior of blink and webkit we need to use imgIRequest::GetCORSMode to get the request's cors mode and add logic to this check to ensure we do not take that branch that ignores image-orientation: none in the case that imgIRequest::GetCORSMode returned CORS_ANONYMOUS.

That being said, it is unclear to me currently if this is the expected or correct behavior. Based on the discussion in w3c/csswg-drafts#5165, I'd think we'd want to ignore image-orientation: none regardless of crossorigin="anonymous".

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1655598

Comment 4

[Dan Robertson (:dlrobertson)]

Attachment: Bug 1822116 - image-orientation: none should apply to CORS image requests. r=emilio

The image-orientation: none property should apply to images with
crossorigin="anonymous".

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1655598

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa0c6e706e6f
image-orientation: none should apply to CORS image requests. r=emilio

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/39513 for changes under testing/web-platform/tests

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/aa0c6e706e6f

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:dlrobertson, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox113 to wontfix.

For more information, please visit auto_nag documentation.

Comment 11

[Dan Robertson (:dlrobertson)]

IMO not important enough for a uplift.

Comment 12

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2023-04-10 Nightly build on Windows 10.
Verified as fixed on Firefox 114.0b2(build ID: 20230509180058) and Nightly 115.0a1(build ID: 20230509215006) on Windows 10, macOS 12, Ubuntu 22.