1822138 - We don't need to handle multiple WriteCallbacks for datagrams before connection

Status: RESOLVED FIXED

(Core :: Networking, defect, P2)

Description

[Randell Jesup [:jesup] (needinfo me)]

Per Kagami, there's no issue with getting multiple WriteCallbacks before we resolve the promise from the first, so we don't need to queue a list of datagrams before connection is made.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1822138: We don't need to queue multiple datagrams for sending once connected r=saschanaz

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c93fec9914f5
We don't need to queue multiple datagrams for sending once connected r=saschanaz

Comment 3

[Cristian Tuns]

Backed out for causing build bustages on WebTransportDatagramDuplexStream.cpp

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/workspace/obj-build/dist/include/mozilla/dom/Promise.h:300:33: error: function 'mozilla::dom::Promise::ThenWithCycleCollectedArgs<(lambda at /builds/worker/checkouts/gecko/dom/webtransport/api/WebTransportDatagramDuplexStream.cpp:190:13), RefPtr<mozilla::dom::IncomingDatagramStreamAlgorithms> &, RefPtr<mozilla::dom::Promise> &>' is used but not defined in this translation unit, and cannot be defined in any other translation unit

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e9dedf6b5215
We don't need to queue multiple datagrams for sending once connected r=saschanaz

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e9dedf6b5215