1822148 - Android Components: exception in release builds when serializing crash pings

Status: RESOLVED FIXED

(Fenix :: Crash Reporting, defect, P2)

Description

[Alex Franchuk [:afranchuk]]

There is an exception when the new Glean crash pings are serialized. The kotlinx serialization cannot find the @Serializable implementation for GleanCrashAction.

Comment 1

[BMO Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1822148 - Android Components: exception in release builds when se… (#1216)

Comment 2

[Alex Franchuk [:afranchuk]]

Attachment: pr 1216: Bug 1822148 - Android Components: exception in release builds when se…

Comment 3

[BMO Github Automation]

Authored by https://github.com/afranchuk
https://github.com/mozilla-mobile/firefox-android/commit/f719eafe517feb03da188768e783bf523ea0e886
[main] Bug 1822148 - Android Components: exception in release builds when serializing crash pings

Comment 4

[Chris Peterson [:cpeterson]]

(In reply to Alex Franchuk from comment #0)

There is an exception when the new Glean crash pings are serialized. The kotlinx serialization cannot find the @Serializable implementation for GleanCrashAction.

Alex, do these Glean crash ping crashes affect Fenix 112 or 111? Or only 113?

Comment 5

[Alex Franchuk [:afranchuk]]

The exceptions would only affect Fenix 112.

Comment 6

[Chris Peterson [:cpeterson]]

(In reply to Alex Franchuk from comment #5)

The exceptions would only affect Fenix 112.

Version 112 is in Fenix Beta now. Should we uplift your fix to Beta 112?

Comment 7

[Mira Lobontiu (Android QA)]

I'll remove the qe-verify+ flag, since there is no need for QA verification.

Comment 8

[Alex Franchuk [:afranchuk]]

(In reply to Chris Peterson [:cpeterson] from comment #6)

(In reply to Alex Franchuk from comment #5)

The exceptions would only affect Fenix 112.

Version 112 is in Fenix Beta now. Should we uplift your fix to Beta 112?

We could, however it's worth noting that this exception doesn't affect user experience in any way. It basically becomes a log message but doesn't break any other behavior. But uplifting into the beta will allow us to get crash pings from more users sooner.

Comment 9

[Chris Peterson [:cpeterson]]

We could, however it's worth noting that this exception doesn't affect user experience in any way. It basically becomes a log message but doesn't break any other behavior. But uplifting into the beta will allow us to get crash pings from more users sooner.

In that case, let's not bother uplifting. The Android team is not yet monitoring crash pings, so this fix can ride the trains with 113.