1822173 - push_official_branch.sh runs in the wrong working directory

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P2)

Description

[Andreas Pehrson [:pehrsons]]

Per the wiki:

• After the merge from elm to mozilla-central is complete, the moz-libwebrtc github repo should be updated with the new branch of the commit stack for the new release. There is script that will make the proper branch name and do the push:

bash dom/media/webrtc/third_party_build/push_official_branch.sh

This is a relative path so it assumes to be run from the elm checkout. The script itself confirms this.

Yet it tries to run git commands for the moz-libwebrtc git repo in the current working directory (elm).

This cannot work.

If the elm checkout uses git-cinnabar it would get more interesting, but I instead hit an error that there is no .git directory so therefore not a git repo.

There is also the problem that if the script was interrupted it cannot be run again. For instance if aborted due to not having push rights to the upstream moz-libwebrtc repo, then after fixing you get fatal: A branch named 'moz-mods-chr109-for-rel113' already exists..

Comment 1

[Michael Froman [:mjf]]

Attachment: Bug 1822173 - push_official_branch must 'cd' to the moz-libwebrtc source directory. r?pehrsons!

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The following patch is waiting for review from a reviewer who resigned from the review:

ID	Title	Author	Reviewer Status
D172551	Bug 1822173 - push_official_branch must 'cd' to the moz-libwebrtc source directory. r?pehrsons!	mjf	pehrsons: Resigned from review

:mjf, could you please find another reviewer?

For more information, please visit auto_nag documentation.

Comment 3

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1822173 - cd to moz-libwebrtc before branching. r?mjf!

Comment 4

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1822173 - Make push_official_branch.sh idempotent and able to continue after interruption. r?mjf!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ea17fade49b
cd to moz-libwebrtc before branching. r=mjf
https://hg.mozilla.org/integration/autoland/rev/fc58c6e8c1fb
Make push_official_branch.sh idempotent and able to continue after interruption. r=mjf

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/4ea17fade49b
https://hg.mozilla.org/mozilla-central/rev/fc58c6e8c1fb